[fix][broker][branch-2.11] fix delete_when_subscriptions_caught_up doesn't work while have active consumers - #18320
Merged
Technoboy- merged 2 commits intoNov 5, 2022
Conversation
Contributor
Author
|
/pulsarbot run-failure-checks |
Technoboy-
approved these changes
Nov 4, 2022
…esn't work while have active consumers
Technoboy-
force-pushed
the
penghui/cherry-pick-18283
branch
from
November 4, 2022 14:35
9d88bd0 to
a3115bd
Compare
13 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current behavior for the
delete_when_subscriptions_caught_upstrategy is not expected. The active consumer will not be closed even if users enabledelete_when_subscriptions_caught_upand there are no backlogs for the topic.It should be the part that #6077 has missed. And Sijie has mentioned in the comment #6077 (review).
To correct the behavior of
delete_when_subscriptions_caught_upModifications
Close active consumers if
delete_when_subscriptions_caught_upis applied and there are no backlogs for the topic. So that the topic can be cleaned up properly by the topic GC thread.Verifying this change
Updated the existing test.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete