[improve][test] Add subscribing regex topic test for delete_when_subscriptions_caught_up. - #18368
Conversation
Technoboy-
changed the title
delete_when_subscriptions_caught_up.delete_when_subscriptions_caught_up.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18368 +/- ##
============================================
- Coverage 47.23% 45.04% -2.19%
- Complexity 10430 10639 +209
============================================
Files 692 757 +65
Lines 67766 72782 +5016
Branches 7260 7826 +566
============================================
+ Hits 32009 32788 +779
- Misses 32192 36335 +4143
- Partials 3565 3659 +94
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| Assert.assertFalse(admin.topics().getList("prop/ns-abc").contains(topic2)); | ||
| }); | ||
| consumer.close(); | ||
| consumer2.close(); |
There was a problem hiding this comment.
We should check that consumer2 has no internal consumers eventually or we can say all the internal consumers are closed due to the topic being deleted.
There was a problem hiding this comment.
Ah, line 358 has checked all the consumers.
gaoran10
left a comment
gaoran10
left a comment
There was a problem hiding this comment.
Sorry, I have a little confused, why the topic can be deleted? It seems the topic has connected consumers.
Ah, some motivation and modification can be found here #18283 |
9ea0a2b to
2b81800
Compare
7 participants
Motivation
Add subscribing regex topic test for #18283.
Documentation
docdoc-requireddoc-not-neededdoc-complete