[improve][broker] ENABLE_IO_URING property name - #18402
Conversation
|
This feature should add a documentation. |
Which should be added to the section is better? |
|
|
@coderzc can you pls provide more context about this improvement?
|
This is network IO mode that can improve performance under specific operating system, but this feature is still considered experimental, you need to enable it with a system property. |
tisonkun
left a comment
There was a problem hiding this comment.
Still I'd prefer enableUring which I believe follow both Java's and IOUring's idom.
The document part can be a separate issue.
+1 to merge.
…y/EventLoopUtil.java Co-authored-by: tison <wander4096@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18402 +/- ##
============================================
+ Coverage 46.98% 47.25% +0.26%
- Complexity 10343 10419 +76
============================================
Files 692 697 +5
Lines 67766 67970 +204
Branches 7259 7275 +16
============================================
+ Hits 31842 32116 +274
+ Misses 32344 32272 -72
- Partials 3580 3582 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Meriging... |
Motivation
#18385 (comment)
Modifications
improve ENABLE_IO_URING property name
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: