Skip to content

[improve][broker] ENABLE_IO_URING property name - #18402

Merged
tisonkun merged 2 commits into
apache:masterfrom
coderzc:io_uring_property
Nov 15, 2022
Merged

[improve][broker] ENABLE_IO_URING property name#18402
tisonkun merged 2 commits into
apache:masterfrom
coderzc:io_uring_property

Conversation

@coderzc

@coderzc coderzc commented Nov 10, 2022

Copy link
Copy Markdown
Member

Motivation

#18385 (comment)

Modifications

improve ENABLE_IO_URING property name

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Nov 10, 2022
@coderzc

coderzc commented Nov 10, 2022

Copy link
Copy Markdown
Member Author

/cc @tisonkun @nodece

@nodece
nodece requested a review from tisonkun November 10, 2022 04:03
@nodece

nodece commented Nov 10, 2022

Copy link
Copy Markdown
Member

This feature should add a documentation.

@coderzc

coderzc commented Nov 10, 2022

Copy link
Copy Markdown
Member Author

This feature should add a documentation.

Which should be added to the section is better?

@nodece

nodece commented Nov 10, 2022

Copy link
Copy Markdown
Member

This feature should add a documentation.

Which should be added to the section is better?

/cc @momo-jun @Anonymitaet

@momo-jun

Copy link
Copy Markdown
Contributor

@coderzc can you pls provide more context about this improvement?

  1. What is the pain point or challenge that it solves? How it helps users?
  2. What is the best way for a user to take advantage of it? If this is a change to something that already exists, what does the user need to do differently as a result?
  3. Any use case or technical assumptions? And how to use it?

@coderzc

coderzc commented Nov 10, 2022

Copy link
Copy Markdown
Member Author

@coderzc can you pls provide more context about this improvement?

  1. What is the pain point or challenge that it solves? How it helps users?
  2. What is the best way for a user to take advantage of it? If this is a change to something that already exists, what does the user need to do differently as a result?
  3. Any use case or technical assumptions? And how to use it?

This is network IO mode that can improve performance under specific operating system, but this feature is still considered experimental, you need to enable it with a system property.

@tisonkun tisonkun changed the title improve ENABLE_IO_URING property name [improve][broker] ENABLE_IO_URING property name Nov 14, 2022

@tisonkun tisonkun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still I'd prefer enableUring which I believe follow both Java's and IOUring's idom.

The document part can be a separate issue.

+1 to merge.

…y/EventLoopUtil.java

Co-authored-by: tison <wander4096@gmail.com>
@codecov-commenter

codecov-commenter commented Nov 14, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.25%. Comparing base (b31c5a6) to head (08df150).
⚠️ Report is 3355 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18402      +/-   ##
============================================
+ Coverage     46.98%   47.25%   +0.26%     
- Complexity    10343    10419      +76     
============================================
  Files           692      697       +5     
  Lines         67766    67970     +204     
  Branches       7259     7275      +16     
============================================
+ Hits          31842    32116     +274     
+ Misses        32344    32272      -72     
- Partials       3580     3582       +2     
Flag Coverage Δ
unittests 47.25% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 62 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tisonkun

Copy link
Copy Markdown
Member

Meriging...

@tisonkun
tisonkun merged commit 2a936f8 into apache:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/broker doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants