[refactor][doc] Improve schema docs - #18434
Merged
Merged
Conversation
4 tasks
momo-jun
marked this pull request as ready for review
November 28, 2022 09:07
labuladong
reviewed
Nov 28, 2022
labuladong
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your work! Leave some style suggestions in the comments.
codelipenghui
requested review from
congbobo184,
gaoran10 and
liangyepianzhou
November 28, 2022 11:54
1 task
Contributor
Author
|
@labuladong thanks for your review. Comments have been addressed. PTAL. @congbobo184 @liangyepianzhou @RobertIndie Do you have any other review comments? |
liangyepianzhou
approved these changes
Dec 7, 2022
RobertIndie
reviewed
Dec 7, 2022
RobertIndie
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution! I left some comments here.
congbobo184
approved these changes
Dec 12, 2022
RobertIndie
reviewed
Dec 12, 2022
labuladong
reviewed
Dec 12, 2022
Contributor
Author
|
@RobertIndie @labuladong Thanks very much for your concrete review. Comments have been addressed. PTAL. |
RobertIndie
approved these changes
Dec 13, 2022
RobertIndie
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for your great work.
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a follow-up PR to #18242 to improve the Schema docs, aiming to provide Pulsar users with a more accurate, easy-to-read, and comprehensive information experience.
Modifications
The content is revised and reviewed through Google docs.
How Pulsar schema works.schema evolutionand subtopics intoUnderstand schema.native Avrotostructschema.Many thanks to @congbobo184, @liangyepianzhou and @RobertIndie for providing technical inputs and review comments.
//cc @Anonymitaet @DaveDuggins @D-2-Ed
Documentation
docdoc-requireddoc-not-neededdoc-complete