Skip to content

[fix][doc] Add client config override - #18492

Closed
momo-jun wants to merge 1 commit into
apache:masterfrom
momo-jun:config-override
Closed

[fix][doc] Add client config override#18492
momo-jun wants to merge 1 commit into
apache:masterfrom
momo-jun:config-override

Conversation

@momo-jun

@momo-jun momo-jun commented Nov 16, 2022

Copy link
Copy Markdown
Contributor

Fixes #18490

Modifications

Add back the configuration override information introduced in #15818 but missed on the new Pulsar config site.

image

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions Bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Nov 16, 2022
@momo-jun

momo-jun commented Nov 16, 2022

Copy link
Copy Markdown
Contributor Author

With @tisonkun's help, I managed to add this chunk of information to the new Pulsar config page (in the Pulsar-site repo) and verify the changes. See apache/pulsar-site#294 for more details.

Maintaining the content in the new config page has pros/cons:

  1. Pros: information is cohesive without a break.
  2. Cons: not that easier for contributors/maintainers to update and verify, compared with the current config page.

Generally, I prefer to add this chunk to the new config page. If you don't have an objection, I will close this PR and continue with apache/pulsar-site#294.

cc @Anonymitaet @DaveDuggins @D-2-Ed

@Anonymitaet

Copy link
Copy Markdown
Member

I'm +1 for apache/pulsar-site#294, reasons:

  • All relevant info is in one place. Docs are not scattered around here and there. It's easier for both readers and maintainers.
  • Explained in the image

image

@momo-jun momo-jun closed this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc] Add the missing configuration override information

2 participants