[fix][offload] Fix memory leak while Offloading ledgers - #18500
Merged
Conversation
- BlockAwareSegmentInputStreamImpl never releases the BookKeeper entries in the close method
eolivelli
added
release/2.11.0
ready-to-test
and removed
doc-not-needed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18500 +/- ##
============================================
+ Coverage 45.62% 46.93% +1.31%
- Complexity 10075 10395 +320
============================================
Files 697 697
Lines 68024 68028 +4
Branches 7293 7291 -2
============================================
+ Hits 31033 31931 +898
+ Misses 33413 32510 -903
- Partials 3578 3587 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
codelipenghui
approved these changes
Nov 16, 2022
codelipenghui
added
type/bug
codelipenghui
changed the title
tjiuming
approved these changes
Nov 16, 2022
eolivelli
added a commit
that referenced
this pull request
Nov 16, 2022
(cherry picked from commit 6ff7d45)
eolivelli
added a commit
that referenced
this pull request
Nov 16, 2022
(cherry picked from commit 6ff7d45)
eolivelli
added a commit
that referenced
this pull request
Nov 16, 2022
(cherry picked from commit 6ff7d45)
eolivelli
added
cherry-picked/branch-2.9
eolivelli
added a commit
to datastax/pulsar
that referenced
this pull request
Nov 16, 2022
(cherry picked from commit 6ff7d45)
Contributor
|
Nice catch! |
Member
|
Tagging #15063 since that's where the issue slipped in. |
congbobo184
pushed a commit
that referenced
this pull request
Nov 26, 2022
(cherry picked from commit 6ff7d45)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Fix the "if" condition.
Verifying this change
This change added tests
Documentation
docdoc-requireddoc-not-neededdoc-complete