[fix][test] Fix flaky test AdditionalServletsTest.testEmptyStringAsExtractionDirectory - #18607
Merged
Conversation
lhotari
approved these changes
Nov 24, 2022
Member
|
/pulsarbot rerun-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #18607 +/- ##
============================================
- Coverage 47.72% 41.63% -6.09%
+ Complexity 9330 2407 -6923
============================================
Files 618 235 -383
Lines 58568 16666 -41902
Branches 6093 1818 -4275
============================================
- Hits 27951 6939 -21012
+ Misses 27589 8968 -18621
+ Partials 3028 759 -2269
Flags with carried forward coverage won't be shown. Click here to find out more. |
nicoloboschi
approved these changes
Nov 24, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
…tractionDirectory (apache#18607)
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
…tractionDirectory (apache#18607)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 20, 2025
…tractionDirectory (apache#18607) (cherry picked from commit bf3ee85)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18587
Motivation
AdditionalServletsTest.testEmptyStringAsExtractionDirectory is flaky because it depends on NarClassLoader#DEFAULT_NAR_EXTRACTION_DIR being initialized after the test is begun.
Modifications
Remove the override of the tmp directory from the test.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: andrasbeni#8