Skip to content

[fix][doc]Add docs for ThresholdShedder - #18675

Merged
315157973 merged 9 commits into
apache:masterfrom
315157973:doc-1
Nov 30, 2022
Merged

[fix][doc]Add docs for ThresholdShedder#18675
315157973 merged 9 commits into
apache:masterfrom
315157973:doc-1

Conversation

@315157973

@315157973 315157973 commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Motivation

Add docs for ThresholdShedder
#17456

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions Bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Nov 29, 2022
@315157973 315157973 changed the title [doc][broker]Add docs for ThresholdShedder [fix][doc]Add docs for ThresholdShedder Nov 29, 2022
@315157973 315157973 mentioned this pull request Nov 29, 2022
Merged
Anonymitaet
Anonymitaet approved these changes Nov 30, 2022
View reviewed changes
Comment thread site2/docs/administration-load-balance.md Outdated
Comment thread site2/docs/administration-load-balance.md Outdated
Comment thread site2/docs/administration-load-balance.md Outdated
Comment thread site2/docs/administration-load-balance.md Outdated
@Anonymitaet Anonymitaet added this to the 2.11.0 milestone Nov 30, 2022
315157973 and others added 4 commits November 30, 2022 10:20
@315157973 @Anonymitaet
Update site2/docs/administration-load-balance.md
4b2b817 
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@315157973 @Anonymitaet
Update site2/docs/administration-load-balance.md
e7a33e9 
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@315157973 @Anonymitaet
Update site2/docs/administration-load-balance.md
8d2a313 
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@315157973 @Anonymitaet
Update site2/docs/administration-load-balance.md
810f791 
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
momo-jun
momo-jun reviewed Nov 30, 2022
View reviewed changes
Comment thread site2/docs/administration-load-balance.md Outdated
momo-jun
momo-jun reviewed Nov 30, 2022
View reviewed changes
Comment thread site2/docs/administration-load-balance.md Outdated
315157973 and others added 2 commits November 30, 2022 10:24
@315157973 @momo-jun
Update site2/docs/administration-load-balance.md
9ab0be5 
Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com>
@315157973 @momo-jun
Update site2/docs/administration-load-balance.md
b774f5e 
Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com>
momo-jun
momo-jun reviewed Nov 30, 2022
View reviewed changes
Comment thread site2/docs/administration-load-balance.md Outdated
momo-jun
momo-jun reviewed Nov 30, 2022
View reviewed changes
Comment thread site2/docs/administration-load-balance.md Outdated
@momo-jun

momo-jun commented Nov 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@315157973 thanks for adding the docs!
Since it works on top of ThresholdShedder, does it make sense to move this newly added content a bit later (starting from Row168), following the complete content of ThresholdShedder?

315157973 and others added 2 commits November 30, 2022 15:05
@315157973 @momo-jun
Update site2/docs/administration-load-balance.md
20b70b0 
Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com>
@315157973 @momo-jun
Update site2/docs/administration-load-balance.md
7e56dda 
Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com>
@315157973

315157973 commented Nov 30, 2022

Copy link
Copy Markdown
Contributor Author

@315157973 thanks for adding the docs! Since it works on top of ThresholdShedder, does it make sense to move this newly added content a bit later (starting from Row168), following the complete content of ThresholdShedder?

This part explain the load balancing strategy. If we divide them into two parts, the meaning will be incoherent

@momo-jun

momo-jun commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

@315157973 thanks for adding the docs! Since it works on top of ThresholdShedder, does it make sense to move this newly added content a bit later (starting from Row168), following the complete content of ThresholdShedder?

This part explain the load balancing strategy. If we divide them into two parts, the meaning will be incoherent

Also make sense. My thought - it breaks the coherent content of ThresholdShedder and also has a dependency on the configuration of ThresholdShedder, so it looks a bit advancing if we introduce it ahead of ThresholdShedder. It's not a broker anyway :)

@315157973
315157973 merged commit 02ef9ce into apache:master Nov 30, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
@315157973 @Anonymitaet
@momo-jun @lifepuzzlefun
[fix][doc]Add docs for ThresholdShedder (apache#18675)
1ee6f6e 
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com>
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
@315157973 @Anonymitaet
@momo-jun @lifepuzzlefun
[fix][doc]Add docs for ThresholdShedder (apache#18675)
9a74a43 
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anonymitaet Anonymitaet Anonymitaet approved these changes
@momo-jun momo-jun momo-jun approved these changes

Assignees

No one assigned

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@315157973 @momo-jun @Anonymitaet