[improve][broker] Making defaultNumberOfNamespaceBundles of ServiceConfiguration dynamic - #18677
Merged
Merged
Conversation
Demogorgon314
left a comment
Demogorgon314
left a comment
Member
There was a problem hiding this comment.
We should update the documentation after this change.
Contributor
Author
It seems that there is a tools to auto gen the document @Demogorgon314 , #18132 |
Demogorgon314
approved these changes
Dec 1, 2022
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18677 +/- ##
============================================
+ Coverage 47.67% 47.85% +0.17%
- Complexity 9333 10570 +1237
============================================
Files 618 698 +80
Lines 58586 68328 +9742
Branches 6098 7332 +1234
============================================
+ Hits 27933 32695 +4762
- Misses 27623 31978 +4355
- Partials 3030 3655 +625
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
…nfiguration dynamic (apache#18677)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Making defaultNumberOfNamespaceBundles of
ServiceConfigurationdynamic.The scenario is that we may create a lot of topics with different namespaces in the future, but finding that the
defaultNumberOfNamespaceBundlesis not suitable, so it's better we could change thedefaultNumberOfNamespaceBundlesdynamicModifications
Make defaultNumberOfNamespaceBundles of
ServiceConfigurationdynamic.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: AnonHxy#19