[fix][test] flaky test testCanRecoverConsumptionWhenLiftMaxUnAckedMessagesRestriction - #18726
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18726 +/- ##
============================================
- Coverage 47.74% 46.95% -0.79%
+ Complexity 10623 10552 -71
============================================
Files 703 703
Lines 68828 68828
Branches 7381 7381
============================================
- Hits 32861 32319 -542
- Misses 32307 32874 +567
+ Partials 3660 3635 -25
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
coderzc
approved these changes
Dec 5, 2022
Contributor
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot rerun-failure-checks |
codelipenghui
approved these changes
Dec 5, 2022
Contributor
Author
|
/pulsarbot rerun-failure-checks |
2 similar comments
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
This pr is ready to merge ^_^ |
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 26, 2022
…ssagesRestriction` (apache#18726)
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 29, 2022
…ssagesRestriction` (apache#18726)
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
…ssagesRestriction` (apache#18726)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jan 12, 2024
…ssagesRestriction` (apache#18726) (cherry picked from commit 2d205c9) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Jan 16, 2024
* [fix][broker] Fix incorrect unack msk count when dup ack a message (apache#20990) (cherry picked from commit 4facdad) Signed-off-by: Zixuan Liu <nodeces@gmail.com> * [fix][test] flaky test `testCanRecoverConsumptionWhenLiftMaxUnAckedMessagesRestriction` (apache#18726) (cherry picked from commit 2d205c9) Signed-off-by: Zixuan Liu <nodeces@gmail.com> --------- Co-authored-by: Jiwei Guo <technoboy@apache.org> Co-authored-by: labuladong <labuladong@foxmail.com>
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 8, 2024
…ssagesRestriction` (apache#18726) (cherry picked from commit 2d205c9) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 8, 2024
…ssagesRestriction` (apache#18726) (cherry picked from commit 2d205c9)
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Mar 15, 2024
* [fix][broker] Fix incorrect unack msk count when dup ack a message (apache#20990) (cherry picked from commit 4facdad) Signed-off-by: Zixuan Liu <nodeces@gmail.com> * [fix][test] flaky test `testCanRecoverConsumptionWhenLiftMaxUnAckedMessagesRestriction` (apache#18726) (cherry picked from commit 2d205c9) Signed-off-by: Zixuan Liu <nodeces@gmail.com> --------- Co-authored-by: Jiwei Guo <technoboy@apache.org> Co-authored-by: labuladong <labuladong@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18617
Modifications
The reason for
Awaitilitytimeout:pulsar/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/KeySharedSubscriptionTest.java
Lines 142 to 155 in 3df506d
The producer didn't set a
keyfor msg, so even if there are 3key_sharedconsumers, there is only 1 consumer to receive messages.Then this consumer will sync receive and sync ack 1000 messages in 10 - 5 = 5 seconds, a little hurry:
pulsar/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/KeySharedSubscriptionTest.java
Lines 172 to 177 in 3df506d
Solution:
Construct keys for messages, and ensure all 3 consumers can handle messages.
Give more time to wait for all consumers to handle messages.
Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: labuladong#15