Skip to content

[fix][client] Fix update response body text #18794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tuteng merged 2 commits into from
Dec 15, 2022
Merged

[fix][client] Fix update response body text #18794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeffd2a
Update resposne body when request failed
tuteng Dec 6, 2022
63e4b48
Fixed test
tuteng Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiSchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ public void testInvalidSchemaDataException(ApiVersion version) {
admin.schemas().createSchema(topicName, schemaInfo);
} catch (PulsarAdminException e) {
Assert.assertEquals(e.getStatusCode(), 422);
Assert.assertEquals(e.getMessage(), "HTTP 422 Invalid schema definition data for AVRO schema");
Assert.assertTrue(e.getMessage().contains("Invalid schema definition data for AVRO schema"));
}
}

Expand Down
3 changes: 3 additions & 0 deletions ...-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,9 @@ public Status.Family getFamily() {

@Override
public String getReasonPhrase() {
if (response.hasResponseBody()) {
return response.getResponseBody();
}
return response.getStatusText();
}
});
Expand Down