[improve][doc] ProducerBuilder.java - #18809
Merged
tisonkun merged 3 commits intoDec 13, 2022
Merged
Conversation
tisonkun
reviewed
Dec 9, 2022
tisonkun
left a comment
Member
There was a problem hiding this comment.
Thanks for taking care of the javadoc!
Comments inline.
Co-authored-by: tison <wander4096@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #18809 +/- ##
============================================
- Coverage 44.79% 41.62% -3.17%
+ Complexity 10026 2406 -7620
============================================
Files 703 235 -468
Lines 68808 16677 -52131
Branches 7375 1819 -5556
============================================
- Hits 30822 6942 -23880
+ Misses 34378 8977 -25401
+ Partials 3608 758 -2850
Flags with carried forward coverage won't be shown. Click here to find out more. |
RobertIndie
approved these changes
Dec 13, 2022
Member
|
Merging... |
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 26, 2022
Co-authored-by: tison <wander4096@gmail.com>
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 29, 2022
Co-authored-by: tison <wander4096@gmail.com>
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
Co-authored-by: tison <wander4096@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Improve the comments in ProducerBuilder.java for clarity and cleanliness.
These can be the first documentation devs see in an IDE, so they should inspire more confidence in users.
Modifications
Cleaned up the comments in the ProducerBuilder.java file.
Verifying this change
[improve][doc] ProducerBuilder.java mendonk/pulsar#1
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete