[feat][doc] Sync 2.9.4-specific updates to 2.9.x docs - #18830
Closed
momo-jun wants to merge 6 commits into
Closed
Conversation
github-actions
Bot
added
the
doc
momo-jun
changed the title
This reverts commit fd4684a.
tisonkun
reviewed
Dec 9, 2022
tisonkun
left a comment
tisonkun
left a comment
Member
There was a problem hiding this comment.
Interesting. Does it mean that we add new configure option even in a patch release?
Contributor
Author
Seems true and there is no boundary clarified on this as far as I know. Maybe it was added for specific users to fix their needs with an upgrade. |
momo-jun
marked this pull request as ready for review
December 29, 2022 03:09
momo-jun
requested review from
Anonymitaet,
congbobo184 and
michaeljmarshall
December 29, 2022 03:10
Anonymitaet
approved these changes
Dec 29, 2022
| # When using the InMemoryDelayedDeliveryTrackerFactory (the default DelayedDeliverTrackerFactory), whether | ||
| # the deliverAt time is strictly followed. When false (default), messages may be sent to consumers before the deliverAt | ||
| # time by as much as the tickTimeMillis. This can reduce the overhead on the broker of maintaining the delayed index | ||
| # for a potentially very short time period. When true, messages will not be sent to consumer until the deliverAt time |
Member
There was a problem hiding this comment.
Suggested change
| # for a potentially very short time period. When true, messages will not be sent to consumer until the deliverAt time | |
| # for a potentially very short time period. When true, messages are not sent to consumers until the deliverAt time |
Contributor
Author
|
Since the docs have been migrated to the Pulsar-site repo, so I've replicated the updates in apache/pulsar-site#350 and closed this PR. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications
Sync 2.9.4-specific updates to 2.9.x docs as per
Documentation
docdoc-requireddoc-not-neededdoc-complete