[improve][cli] handle help flag properly - #18832
Merged
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #18832 +/- ##
============================================
+ Coverage 46.42% 47.68% +1.25%
- Complexity 10437 10625 +188
============================================
Files 703 703
Lines 68816 68838 +22
Branches 7377 7379 +2
============================================
+ Hits 31950 32822 +872
+ Misses 33252 32336 -916
- Partials 3614 3680 +66
Flags with carried forward coverage won't be shown. Click here to find out more.
|
yuruguo
reviewed
Dec 9, 2022
Signed-off-by: tison <wander4096@gmail.com>
nicoloboschi
approved these changes
Dec 12, 2022
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 26, 2022
Signed-off-by: tison <wander4096@gmail.com>
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 29, 2022
Signed-off-by: tison <wander4096@gmail.com>
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
Signed-off-by: tison <wander4096@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently
With this patch
$ ./bin/pulsar-admin schemas -h Usage: pulsar-admin schemas [options] [command] [command options] Commands: get Get the schema for a topic Usage: get [options] persistent://tenant/namespace/topic Options: -a, --all-version all version Default: false -v, --version version delete Delete the latest schema for a topic Usage: delete [options] persistent://tenant/namespace/topic Options: -f, --force whether to delete schema completely. If true, delete all resources (including metastore and ledger), otherwise only do a mark deletion and not remove any resources indeed Default: false upload Update the schema for a topic Usage: upload [options] persistent://tenant/namespace/topic Options: * -f, --filename filename extract Provide the schema via a topic Usage: extract [options] persistent://tenant/namespace/topic Options: -a, --always-allow-null set schema whether always allow null or not Default: true * -c, --classname class name of pojo -n, --dry-run dost not apply to schema registry, just prints the post schema payload Default: false * -j, --jar jar filepath * -t, --type type avro or json$ ./bin/pulsar-admin schemas delete -h Usage: pulsar-admin schemas delete [options] persistent://tenant/namespace/topic Options: -f, --force whether to delete schema completely. If true, delete all resources (including metastore and ledger), otherwise only do a mark deletion and not remove any resources indeed Default: falseDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: