Skip to content

[improve][broker] Fast return when AppendIndexMetadataInterceptor is matched. - #18884

Merged
RobertIndie merged 1 commit into
apache:masterfrom
Nicklee007:match-AppendIndexMetadataInterceptor-fast-return
Dec 12, 2022
Merged

[improve][broker] Fast return when AppendIndexMetadataInterceptor is matched.#18884
RobertIndie merged 1 commit into
apache:masterfrom
Nicklee007:match-AppendIndexMetadataInterceptor-fast-return

Conversation

@Nicklee007

@Nicklee007 Nicklee007 commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

Motivation

Optimize the method, fast return when AppendIndexMetadataInterceptor is matched.

Modifications

  1. Fast return when when AppendIndexMetadataInterceptor is matched.

Documentation

  • doc-not-needed

Matching PR in forked repository

PR in forked repository:Nicklee007#6

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Dec 12, 2022

@Jason918 Jason918 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodece

nodece commented Dec 12, 2022

Copy link
Copy Markdown
Member

/pulsarbot rerun-failure-checks

@codecov-commenter

codecov-commenter commented Dec 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #18884 (d543440) into master (3180a4a) will increase coverage by 2.26%.
The diff coverage is 43.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18884      +/-   ##
============================================
+ Coverage     46.17%   48.43%   +2.26%     
+ Complexity    10359     9575     -784     
============================================
  Files           703      623      -80     
  Lines         68845    59101    -9744     
  Branches       7382     6147    -1235     
============================================
- Hits          31788    28627    -3161     
+ Misses        33448    27378    -6070     
+ Partials       3609     3096     -513     
Flag Coverage Δ
unittests 48.43% <43.75%> (+2.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...broker/intercept/ManagedLedgerInterceptorImpl.java 0.00% <0.00%> (ø)
...va/org/apache/pulsar/client/impl/ConsumerImpl.java 15.09% <0.00%> (-0.04%) ⬇️
...he/pulsar/client/impl/MultiTopicsConsumerImpl.java 22.78% <0.00%> (-0.09%) ⬇️
.../pulsar/broker/service/AbstractBaseDispatcher.java 58.85% <100.00%> (+1.38%) ⬆️
...sistent/PersistentDispatcherMultipleConsumers.java 57.81% <100.00%> (+6.08%) ⬆️
...ker/loadbalance/impl/LeastLongTermMessageRate.java 73.33% <0.00%> (-20.00%) ⬇️
...ersistentStickyKeyDispatcherMultipleConsumers.java 41.17% <0.00%> (-19.12%) ⬇️
...ervice/persistent/MessageRedeliveryController.java 51.21% <0.00%> (-17.08%) ⬇️
...ker/resourcegroup/ResourceGroupConfigListener.java 64.38% <0.00%> (-2.74%) ⬇️
...sar/broker/service/schema/SchemaRegistryStats.java 72.50% <0.00%> (-2.50%) ⬇️
... and 156 more

@Nicklee007

Copy link
Copy Markdown
Contributor Author

/pulsarbot rerun-failure-checks

@RobertIndie
RobertIndie merged commit 9917aac into apache:master Dec 12, 2022
Demogorgon314 pushed a commit to Demogorgon314/pulsar that referenced this pull request Dec 26, 2022
…matched. (apache#18884)

### Motivation

Optimize the method, fast return when AppendIndexMetadataInterceptor is matched.

### Modifications

1. Fast return when when AppendIndexMetadataInterceptor is matched.
Demogorgon314 pushed a commit to Demogorgon314/pulsar that referenced this pull request Dec 29, 2022
…matched. (apache#18884)

### Motivation

Optimize the method, fast return when AppendIndexMetadataInterceptor is matched.

### Modifications

1. Fast return when when AppendIndexMetadataInterceptor is matched.
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
…matched. (apache#18884)

### Motivation

Optimize the method, fast return when AppendIndexMetadataInterceptor is matched.

### Modifications

1. Fast return when when AppendIndexMetadataInterceptor is matched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants