[fix][txn] Fix replication of transactional messages - #18896
Merged
nicoloboschi merged 3 commits intoDec 13, 2022
Conversation
eolivelli
approved these changes
Dec 13, 2022
nicoloboschi
requested review from
315157973,
Jason918,
Technoboy-,
codelipenghui and
congbobo184
December 13, 2022 08:29
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18896 +/- ##
=============================================
+ Coverage 33.99% 47.68% +13.68%
- Complexity 6476 10665 +4189
=============================================
Files 623 703 +80
Lines 59103 68877 +9774
Branches 6147 7386 +1239
=============================================
+ Hits 20095 32847 +12752
+ Misses 36347 32349 -3998
- Partials 2661 3681 +1020
Flags with carried forward coverage won't be shown. Click here to find out more.
|
congbobo184
approved these changes
Dec 13, 2022
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Dec 13, 2022
(cherry picked from commit 83922c2)
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Dec 13, 2022
(cherry picked from commit 83922c2)
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 26, 2022
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 29, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18888
Motivation
Transaction markers and non committed messages should not being replicated by the geo-replicator.
Those messages must appear as normal messages in the destination clusters.
Modifications
Notes: I haven't modified the shadow topic replicator because I'm not sure if that feature is completed or not and in any case it's better to fix it in another pull
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
nicoloboschi#39