[improve][cli] Option to create replicated subscriptions in pulsar-perf txn - #18904
Merged
Merged
Conversation
RobertIndie
approved these changes
Dec 13, 2022
Codecov Report
@@ Coverage Diff @@
## master #18904 +/- ##
============================================
+ Coverage 33.99% 38.49% +4.49%
- Complexity 6476 8231 +1755
============================================
Files 623 703 +80
Lines 59103 68847 +9744
Branches 6147 7381 +1234
============================================
+ Hits 20095 26505 +6410
- Misses 36347 38864 +2517
- Partials 2661 3478 +817
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add option to create replicated subscription in
pulsar-perf transaction.Modifications
-rs, --replicatedto create replicated subs.--replicatedis the same that it's in pulsar-perf consume.-rsalso to pulsar-perf consume for consistencyDocumentation
doc-not-needed