Skip to content

[improve][cli] Option to create replicated subscriptions in pulsar-perf txn - #18904

Merged
nicoloboschi merged 2 commits into
apache:masterfrom
nicoloboschi:perf-replicated-subs
Dec 14, 2022
Merged

[improve][cli] Option to create replicated subscriptions in pulsar-perf txn#18904
nicoloboschi merged 2 commits into
apache:masterfrom
nicoloboschi:perf-replicated-subs

Conversation

@nicoloboschi

Copy link
Copy Markdown
Contributor

Motivation

Add option to create replicated subscription in pulsar-perf transaction.

Modifications

  • -rs, --replicated to create replicated subs. --replicated is the same that it's in pulsar-perf consume.
  • Added -rs also to pulsar-perf consume for consistency
  • FIxed leaks in perf tests

Documentation

  • doc-not-needed

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Dec 13, 2022
@codecov-commenter

codecov-commenter commented Dec 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #18904 (1331041) into master (1be5a69) will increase coverage by 4.49%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18904      +/-   ##
============================================
+ Coverage     33.99%   38.49%   +4.49%     
- Complexity     6476     8231    +1755     
============================================
  Files           623      703      +80     
  Lines         59103    68847    +9744     
  Branches       6147     7381    +1234     
============================================
+ Hits          20095    26505    +6410     
- Misses        36347    38864    +2517     
- Partials       2661     3478     +817     
Flag Coverage Δ
unittests 38.49% <ø> (+4.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ervice/persistent/MessageRedeliveryController.java 63.41% <0.00%> (-4.88%) ⬇️
.../apache/pulsar/client/impl/BatchMessageIdImpl.java 67.50% <0.00%> (-4.73%) ⬇️
...sar/broker/service/schema/SchemaRegistryStats.java 68.75% <0.00%> (-3.75%) ⬇️
...ava/org/apache/pulsar/broker/service/Consumer.java 67.43% <0.00%> (-2.14%) ⬇️
...g/apache/pulsar/broker/lookup/TopicLookupBase.java 44.69% <0.00%> (-1.68%) ⬇️
...ersistentStickyKeyDispatcherMultipleConsumers.java 59.80% <0.00%> (-1.48%) ⬇️
...rvice/nonpersistent/NonPersistentSubscription.java 45.41% <0.00%> (-1.45%) ⬇️
...apache/pulsar/broker/namespace/OwnershipCache.java 68.42% <0.00%> (-1.06%) ⬇️
...rg/apache/pulsar/client/impl/PulsarClientImpl.java 43.85% <0.00%> (-0.95%) ⬇️
...sar/broker/loadbalance/impl/LoadManagerShared.java 38.15% <0.00%> (-0.44%) ⬇️
... and 187 more

@nicoloboschi
nicoloboschi merged commit 9e8bf7a into apache:master Dec 14, 2022
@nicoloboschi
nicoloboschi deleted the perf-replicated-subs branch December 14, 2022 08:03
@nicoloboschi nicoloboschi added this to the 2.12.0 milestone Dec 14, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants