[improve][broker] Only get consumer future when interceptor not null - #19022
Merged
codelipenghui merged 1 commit intoDec 22, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19022 +/- ##
============================================
- Coverage 49.85% 47.12% -2.74%
- Complexity 8658 10620 +1962
============================================
Files 500 709 +209
Lines 54930 69352 +14422
Branches 5867 7440 +1573
============================================
+ Hits 27386 32681 +5295
- Misses 24464 33002 +8538
- Partials 3080 3669 +589
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Dec 22, 2022
codelipenghui
approved these changes
Dec 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Builds on #18997. Essentially, we shouldn't get the consumer future when there isn't a broker interceptor.
Modifications
brokerInterceptor != nullearlier to prevent unnecessary work.Verifying this change
This is a trivial change.
Documentation
doc-not-needed