[fix][broker] Fix configuration exposeSubscriptionBacklogSizeInPrometheus not working - #19049
[fix][broker] Fix configuration exposeSubscriptionBacklogSizeInPrometheus not working#19049Shawyeok wants to merge 1 commit into
Conversation
|
/pulsarbot rerun-failure-checks |
0441fe8 to
09e5f39
Compare
|
/pulsarbot rerun-failure-checks |
|
PTAL @codelipenghui |
09e5f39 to
4dfb6d4
Compare
|
@Shawyeok A PIP is required If the change will introduce a new indicator to the metrics endpoint. Please see https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md and the discussion under the mailing list https://lists.apache.org/thread/bmwtk6zcyt4ft4t95jmz1bnsxbysjw8m I support the motivation. |
Ok, I'll draft a PIP in the weekend. |
|
The pr had no activity for 30 days, mark with Stale label. |
Motivation
Broker configuration
exposeSubscriptionBacklogSizeInPrometheuswas introduced in #9302, but it is true, broker just calculate the size of backlog and didn't expose it.Modifications
exposeSubscriptionBacklogSizeInPrometheus=true, expose the metric aspulsar_subscription_back_log_sizeVerifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
exposeSubscriptionBacklogSizeInPrometheus=false, it shouldn't expose the metricexposeSubscriptionBacklogSizeInPrometheus=true, it should expose the metricDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Shawyeok#6