[fix][doc] Rename LedgerInfo to avoid swagger docs conflict - #19087
Closed
tisonkun wants to merge 2 commits into
Closed
[fix][doc] Rename LedgerInfo to avoid swagger docs conflict#19087tisonkun wants to merge 2 commits into
tisonkun wants to merge 2 commits into
Conversation
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
fix-swagger-2
branch
from
December 28, 2022 06:15
2132454 to
c3a056e
Compare
Codecov Report
@@ Coverage Diff @@
## master #19087 +/- ##
============================================
- Coverage 47.46% 47.38% -0.08%
- Complexity 10727 10728 +1
============================================
Files 711 711
Lines 69456 69461 +5
Branches 7452 7453 +1
============================================
- Hits 32964 32915 -49
- Misses 32810 32857 +47
- Partials 3682 3689 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
requested review from
hezhangjian
and removed request for
AnonHxy,
dlg99 and
yuruguo
December 29, 2022 00:31
Member
|
Do you mean there are two LedgerInfo in the swagger.json? |
Member
Author
Finally there's one, but the field is different because it's randomly generated from |
Member
Author
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See apache/pulsar-site@619e9ec.
These two classes conflict in name:
org.apache.pulsar.common.policies.data.ManagedLedgerInternalStats.LedgerInfoorg.apache.bookkeeper.mledger.ManagedLedgerInfo.LedgerInfoSince the latter one is a public interface while the former one is for internal usage, I tend to rename the former one to deduplicate.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: