[fix][broker][PIP-195] fix cursor skip read

[coderzc]

PIP: #16763

Motivation

In #19035, the skipCondition parameter returns need to skip entry when reading entry, but the logic now is reversed.

Modifications

Fix skip logic and add test to cover it.

Verifying this change

• Make sure that the change passes the CI checks.

testReadEntriesWithSkip

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.38%. Comparing base (9ec1d07) to head (a32996f).
⚠️ Report is 3041 commits behind head on master.

Files with missing lines	Patch %	Lines
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #19124      +/-   ##
============================================
- Coverage     47.73%   47.38%   -0.35%     
+ Complexity    10819    10746      -73     
============================================
  Files           712      712              
  Lines         69645    69644       -1     
  Branches       7481     7480       -1     
============================================
- Hits          33242    33000     -242     
- Misses        32699    32944     +245     
+ Partials       3704     3700       -4     

Flag	Coverage Δ
unittests	47.38% <0.00%> (-0.35%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java	54.16% <0.00%> (+0.33%)	⬆️

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[codelipenghui]

It should be assertEquals(entry.getEntryId() % 2, 0);

And due to this one is executed by the SafeRun, so the test will not get failed event if the assert fails.

[coderzc]

And due to this one is executed by the SafeRun, so the test will not get failed event if the assert fails.

I already use completableFuture.completeExceptionally(e) to receive exception, it should be can work.

But AssertionError is not a subclass of Exception, so we should be caught Throwable.

[codelipenghui]

Same as the above comment. You might need to consider using a different way to assert the result.

[mattisonchao]

I suggest Invert if condition to help simple understand this logic. : )

[coderzc]

Ok.

[mattisonchao]

It looks like this logic just works for the else branch. Can we merge it?

[coderzc]

Yes, we can move this logic to the else branch