[improve][schema] Do not print error log with stacktrace for 404 - #19130
Merged
Conversation
Contributor
Author
|
/pulsarbot run-failure-checks |
nicoloboschi
reviewed
Jan 4, 2023
nicoloboschi
left a comment
Contributor
There was a problem hiding this comment.
What about keeping them a debug level ?
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #19130 +/- ##
============================================
- Coverage 47.73% 45.68% -2.05%
- Complexity 10819 11046 +227
============================================
Files 712 772 +60
Lines 69645 74422 +4777
Branches 7481 8015 +534
============================================
+ Hits 33242 33997 +755
- Misses 32699 36615 +3916
- Partials 3704 3810 +106
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
Hmmm, I don't think it will help something. Because 404 always means the schema is not found or the topic is not found depending on the API. We already have the streamlined log which I mentioned in the PR's description. |
nicoloboschi
approved these changes
Jan 4, 2023
HQebupt
approved these changes
Jan 4, 2023
BewareMyPower
approved these changes
Jan 4, 2023
eolivelli
approved these changes
Jan 4, 2023
codelipenghui
added a commit
that referenced
this pull request
Jan 5, 2023
) (cherry picked from commit 3afc291)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We have the INFO log to show the schema not found, or the topic is found.
The error logs for the not found exception are just making noise.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete