Skip to content

[fix][broker] fix ttl expiration block due to no-recoverable exception even if autoSkipNonRecoverableData=true #19132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aloyszhang merged 1 commit into from
Jan 8, 2023
Merged

[fix][broker] fix ttl expiration block due to no-recoverable exception even if autoSkipNonRecoverableData=true #19132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
import org.apache.bookkeeper.mledger.ManagedLedgerException.ManagedLedgerFencedException;
import org.apache.bookkeeper.mledger.ManagedLedgerException.ManagedLedgerTerminatedException;
import org.apache.bookkeeper.mledger.ManagedLedgerException.MetadataNotFoundException;
import org.apache.bookkeeper.mledger.ManagedLedgerException.NonRecoverableLedgerException;
import org.apache.bookkeeper.mledger.Position;
import org.apache.bookkeeper.mledger.impl.ManagedCursorContainer;
import org.apache.bookkeeper.mledger.impl.ManagedCursorImpl;
Expand Down Expand Up @@ -2853,7 +2854,14 @@ public boolean isOldestMessageExpired(ManagedCursor cursor, int messageTTLInSeco
(int) (messageTTLInSeconds * MESSAGE_EXPIRY_THRESHOLD), entryTimestamp);
}
} catch (Exception e) {
log.warn("[{}] Error while getting the oldest message", topic, e);
if (brokerService.pulsar().getConfiguration().isAutoSkipNonRecoverableData()
Comment thread
aloyszhang marked this conversation as resolved.
&& e instanceof NonRecoverableLedgerException) {
// NonRecoverableLedgerException means the ledger or entry can't be read anymore.
// if AutoSkipNonRecoverableData is set to true, just return true here.
return true;
} else {
log.warn("[{}] Error while getting the oldest message", topic, e);
}
} finally {
if (entry != null) {
entry.release();
Expand Down