[cleanup][txn] Use MLTransactionMetadataStore in integration tests - #19140
Merged
Conversation
codelipenghui
approved these changes
Jan 6, 2023
Contributor
|
/pulsarbot run-failure-checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19140 +/- ##
============================================
+ Coverage 47.00% 47.32% +0.32%
- Complexity 10639 10731 +92
============================================
Files 713 713
Lines 69672 69672
Branches 7482 7482
============================================
+ Hits 32746 32973 +227
+ Misses 33212 33009 -203
+ Partials 3714 3690 -24
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
HQebupt
approved these changes
Jan 6, 2023
Demogorgon314
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Transaction's integration tests use the in memory implementation for the txn metadata store.
Since they're very important test to ensure stability of the transactions feature, it's better to use the default store which is actually designed to run in production environments.
Modifications
InMemTransactionMetadataStoreProviderin the integration tests setupDocumentation
docdoc-requireddoc-not-neededdoc-complete