Skip to content

[cleanup][txn] Use MLTransactionMetadataStore in integration tests - #19140

Merged
nicoloboschi merged 1 commit into
apache:masterfrom
nicoloboschi:txn-int-use-ml
Jan 9, 2023
Merged

[cleanup][txn] Use MLTransactionMetadataStore in integration tests#19140
nicoloboschi merged 1 commit into
apache:masterfrom
nicoloboschi:txn-int-use-ml

Conversation

@nicoloboschi

Copy link
Copy Markdown
Contributor

Motivation

Transaction's integration tests use the in memory implementation for the txn metadata store.
Since they're very important test to ensure stability of the transactions feature, it's better to use the default store which is actually designed to run in production environments.

Modifications

  • Do not set InMemTransactionMetadataStoreProvider in the integration tests setup

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@codelipenghui codelipenghui added this to the 2.12.0 milestone Jan 6, 2023
@codelipenghui codelipenghui added area/test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use labels Jan 6, 2023
@codelipenghui

Copy link
Copy Markdown
Contributor

/pulsarbot run-failure-checks

@codecov-commenter

codecov-commenter commented Jan 6, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.32%. Comparing base (4b8f447) to head (f8e48e1).
⚠️ Report is 3035 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19140      +/-   ##
============================================
+ Coverage     47.00%   47.32%   +0.32%     
- Complexity    10639    10731      +92     
============================================
  Files           713      713              
  Lines         69672    69672              
  Branches       7482     7482              
============================================
+ Hits          32746    32973     +227     
+ Misses        33212    33009     -203     
+ Partials       3714     3690      -24     
Flag Coverage Δ
unittests 47.32% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicoloboschi
nicoloboschi merged commit 6335fa1 into apache:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants