[improve][broker] Add parameter check for create/update cluster. - #19151
Merged
Conversation
mattisonchao
requested review from
Jason918,
Technoboy-,
codelipenghui,
congbobo184,
eolivelli and
nicoloboschi
January 6, 2023 09:28
Member
Author
|
@codelipenghui @eolivelli @Jason918 @congbobo184 @nicoloboschi |
Codecov Report
@@ Coverage Diff @@
## master #19151 +/- ##
============================================
- Coverage 47.46% 44.29% -3.17%
+ Complexity 10727 10057 -670
============================================
Files 711 713 +2
Lines 69456 69683 +227
Branches 7452 7483 +31
============================================
- Hits 32964 30865 -2099
- Misses 32810 35206 +2396
+ Partials 3682 3612 -70
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattisonchao
added
release/important-notice
mattisonchao
commented
Jan 9, 2023
…ce/LinuxInfoUtils.java
congbobo184
reviewed
Jan 9, 2023
| .allowedClusters(Collections.singleton(cluster)) | ||
| .build(); | ||
| ClusterDataImpl clusterData = ClusterDataImpl.builder().serviceUrl(cluster).build(); | ||
| ClusterDataImpl clusterData = ClusterDataImpl.builder().serviceUrl("http://example.pulsar").build(); |
Contributor
There was a problem hiding this comment.
Is this a breaking change? I haven't reviewed the details.
Member
Author
There was a problem hiding this comment.
It's not a breaking change; we just didn't have data validation.
gaoran10
approved these changes
Jan 9, 2023
coderzc
approved these changes
Jan 9, 2023
congbobo184
approved these changes
Jan 9, 2023
Merged
4 tasks
Member
|
@mattisonchao Is this PR a potential breaking change? Please check #19212 . |
Member
|
@mattisonchao I wonder if a "https" url would need to be accepted in the serviceUrl just because of backwards compatibility reasons? |
Comment on lines
+410
to
+428
| public void checkPropertiesIfPresent() throws IllegalArgumentException { | ||
| URIPreconditions.checkURIIfPresent(getServiceUrl(), | ||
| uri -> Objects.equals(uri.getScheme(), "http"), | ||
| "Illegal service url, example: http://pulsar.example.com:8080"); | ||
| URIPreconditions.checkURIIfPresent(getServiceUrlTls(), | ||
| uri -> Objects.equals(uri.getScheme(), "https"), | ||
| "Illegal service tls url, example: https://pulsar.example.com:8443"); | ||
| URIPreconditions.checkURIIfPresent(getBrokerServiceUrl(), | ||
| uri -> Objects.equals(uri.getScheme(), "pulsar"), | ||
| "Illegal broker service url, example: pulsar://pulsar.example.com:6650"); | ||
| URIPreconditions.checkURIIfPresent(getBrokerServiceUrlTls(), | ||
| uri -> Objects.equals(uri.getScheme(), "pulsar+ssl"), | ||
| "Illegal broker service tls url, example: pulsar+ssl://pulsar.example.com:6651"); | ||
| URIPreconditions.checkURIIfPresent(getProxyServiceUrl(), | ||
| uri -> Objects.equals(uri.getScheme(), "pulsar") | ||
| || Objects.equals(uri.getScheme(), "pulsar+ssl"), | ||
| "Illegal proxy service url, example: pulsar+ssl://ats-proxy.example.com:4443 " | ||
| + "or pulsar://ats-proxy.example.com:4080"); | ||
| } |
Member
There was a problem hiding this comment.
Do we document these requirements? Also, what would happen if a user had already created a cluster in a bad state?
5 tasks
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the current implementation, we didn't have any cluster data check for
create/updatecluster. it may cause some problems when the user sets the wrong URL.Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
Documentation
doc-not-needed