[revert] "[fix][broker] change name limitTime to limitTimeInSec (#19053)" - #19152
Merged
Conversation
michaeljmarshall
added
type/cleanup
michaeljmarshall
requested review from
HQebupt,
congbobo184,
lhotari and
yuruguo
January 6, 2023 19:47
michaeljmarshall
changed the title
15 tasks
mattisonchao
approved these changes
Jan 7, 2023
Jason918
approved these changes
Jan 7, 2023
Member
|
/pulsarbot rerun-failure-checks |
lhotari
approved these changes
Jan 7, 2023
Codecov Report
@@ Coverage Diff @@
## master #19152 +/- ##
============================================
+ Coverage 47.32% 47.42% +0.09%
- Complexity 10731 10755 +24
============================================
Files 713 713
Lines 69672 69672
Branches 7482 7482
============================================
+ Hits 32972 33041 +69
+ Misses 32991 32922 -69
Partials 3709 3709
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eolivelli
approved these changes
Jan 7, 2023
HQebupt
approved these changes
Jan 8, 2023
Contributor
|
@StevenLuMT FYI |
AnonHxy
approved these changes
Jan 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fd5037d.
Motivation
As described in #19053 (review), the commit to be reverted introduced a breaking change in a non-backwards compatible way. This is especially important because the datastructure in question is used for ser/de of zk metadata. Instead of making one-off changes to variable names, I would prefer to first establish a standard/spec, and then apply it generally to all names. Pulsar certainly has room to improve names, but we must prioritize the user experience when changing these names. We also need to make sure that we cover upgrade and downgrade scenarios so that we do not break environments.
Modifications
Verifying this change
This should be trivial.
Does this pull request potentially affect one of the following parts:
This reverts a breaking change.
Documentation
doc-not-neededI'll send an email to the mailing list to discuss how we should handle these in the future.