Skip to content

[cleanup][broker] Remove AuthorizationProvider methods deprecated in 2.7 and 2.9 - #19182

Merged
Technoboy- merged 4 commits into
apache:masterfrom
michaeljmarshall:remove-long-deprecated-methods
Jan 15, 2023
Merged

[cleanup][broker] Remove AuthorizationProvider methods deprecated in 2.7 and 2.9#19182
Technoboy- merged 4 commits into
apache:masterfrom
michaeljmarshall:remove-long-deprecated-methods

Conversation

@michaeljmarshall

@michaeljmarshall michaeljmarshall commented Jan 11, 2023

Copy link
Copy Markdown
Member

Motivation

We have many methods in the AuthorizationProvider interface that have been annotated with @Deprecated for since the 2.7.0 release and the 2.9.0 release. The PR that deprecated most of these methods was merged August 2020: #7788. The other PR was #12064. These methods are not used by the Pulsar code base, but may technically be used by third party extensions, which is why it is important to be careful when removing them. That being said, enough time has passed. Removing these methods should make the AuthorizationProvider easier to read and easier to use.

Modifications

Verifying this change

I reviewed the git history and made sure the project compiles.

Does this pull request potentially affect one of the following parts:

  • The public API

This is technically a breaking change. I will send an email to the mailing list.

Documentation

  • doc-not-needed

We allow the AuthorizationProvider interface itself to be the documentation, so I do not see any need to update docs.

Matching PR in forked repository

Since I already tested the compilation of the project, I see no reason to build in my own fork.

@michaeljmarshall michaeljmarshall added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use release/note-required doc-not-needed Your PR changes do not impact docs ready-to-test area/authz labels Jan 11, 2023
@michaeljmarshall michaeljmarshall added this to the 2.12.0 milestone Jan 11, 2023
@michaeljmarshall michaeljmarshall self-assigned this Jan 11, 2023
@michaeljmarshall michaeljmarshall changed the title [cleanup][broker] Remove AuthorizationProvider methods deprecated in 2.7 [cleanup][broker] Remove AuthorizationProvider methods deprecated in 2.7 and 2.9 Jan 11, 2023
@codecov-commenter

codecov-commenter commented Jan 11, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.48%. Comparing base (4028ad3) to head (bd94835).
⚠️ Report is 3026 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19182      +/-   ##
============================================
+ Coverage     47.45%   47.48%   +0.02%     
- Complexity    10760    10788      +28     
============================================
  Files           713      713              
  Lines         69672    69722      +50     
  Branches       7482     7492      +10     
============================================
+ Hits          33063    33105      +42     
- Misses        32895    32938      +43     
+ Partials       3714     3679      -35     
Flag Coverage Δ
unittests 47.48% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 62 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattisonchao mattisonchao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to notify in the release notion.
By the way, have you checked the corresponding test?

@mattisonchao

Copy link
Copy Markdown
Member

Oh, I saw the label. Please ignore my comment first sentence.

@Technoboy-
Technoboy- merged commit efb251c into apache:master Jan 15, 2023
@michaeljmarshall
michaeljmarshall deleted the remove-long-deprecated-methods branch January 17, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/authz doc-not-needed Your PR changes do not impact docs ready-to-test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants