[fix][broker] Pass subName for subscription operations in ServerCnx - #19184
Merged
michaeljmarshall merged 1 commit intoJan 11, 2023
Merged
Conversation
michaeljmarshall
added
type/bug
michaeljmarshall
requested review from
RobertIndie,
lhotari,
merlimat and
nodece
January 11, 2023 04:54
michaeljmarshall
changed the title
michaeljmarshall
force-pushed
the
fix-subscription
branch
from
January 11, 2023 04:55
e2cbc34 to
4cf657b
Compare
2 tasks
2 tasks
mattisonchao
approved these changes
Jan 11, 2023
coderzc
approved these changes
Jan 11, 2023
michaeljmarshall
added a commit
that referenced
this pull request
Jan 11, 2023
…19184) ### Motivation When a DLQ producer connects, it creates a subscription when configured to do so. The `subscriptionName` should be passed to the `authorizationProvider` to properly determine authorization. ### Modifications * Pass `initialSubscriptionName` to `isTopicOperationAllowed` method in the `ServerCnx`. ### Verifying this change I am going to work on generic tests to cover this case (and some others) when I do #19183. ### Does this pull request potentially affect one of the following parts: This is not a breaking change. ### Documentation - [x] `doc-not-needed` This only impacts users that have subscription level permissions, which are not well documented. We should improve those docs eventually, but there is no need to fix those docs while making this fix. ### Matching PR in forked repository PR in forked repository: michaeljmarshall#11 (cherry picked from commit d96af0a)
michaeljmarshall
added a commit
that referenced
this pull request
Jan 11, 2023
…19184) ### Motivation When a DLQ producer connects, it creates a subscription when configured to do so. The `subscriptionName` should be passed to the `authorizationProvider` to properly determine authorization. ### Modifications * Pass `initialSubscriptionName` to `isTopicOperationAllowed` method in the `ServerCnx`. ### Verifying this change I am going to work on generic tests to cover this case (and some others) when I do #19183. ### Does this pull request potentially affect one of the following parts: This is not a breaking change. ### Documentation - [x] `doc-not-needed` This only impacts users that have subscription level permissions, which are not well documented. We should improve those docs eventually, but there is no need to fix those docs while making this fix. ### Matching PR in forked repository PR in forked repository: michaeljmarshall#11 (cherry picked from commit d96af0a)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 16, 2023
…pache#19184) ### Motivation When a DLQ producer connects, it creates a subscription when configured to do so. The `subscriptionName` should be passed to the `authorizationProvider` to properly determine authorization. ### Modifications * Pass `initialSubscriptionName` to `isTopicOperationAllowed` method in the `ServerCnx`. ### Verifying this change I am going to work on generic tests to cover this case (and some others) when I do apache#19183. ### Does this pull request potentially affect one of the following parts: This is not a breaking change. ### Documentation - [x] `doc-not-needed` This only impacts users that have subscription level permissions, which are not well documented. We should improve those docs eventually, but there is no need to fix those docs while making this fix. ### Matching PR in forked repository PR in forked repository: michaeljmarshall#11 (cherry picked from commit d96af0a) (cherry picked from commit 775d5ad)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a DLQ producer connects, it creates a subscription when configured to do so. The
subscriptionNameshould be passed to theauthorizationProviderto properly determine authorization.Modifications
initialSubscriptionNametoisTopicOperationAllowedmethod in theServerCnx.Verifying this change
I am going to work on generic tests to cover this case (and some others) when I do #19183.
Does this pull request potentially affect one of the following parts:
This is not a breaking change.
Documentation
doc-not-neededThis only impacts users that have subscription level permissions, which are not well documented. We should improve those docs eventually, but there is no need to fix those docs while making this fix.
Matching PR in forked repository
PR in forked repository: michaeljmarshall#11