Skip to content

[fix][cli] Shell syntax - #19188

Merged
tisonkun merged 1 commit into
masterfrom
tisonkun-patch-1
Jan 11, 2023
Merged

[fix][cli] Shell syntax#19188
tisonkun merged 1 commit into
masterfrom
tisonkun-patch-1

Conversation

@tisonkun

@tisonkun tisonkun commented Jan 11, 2023

Copy link
Copy Markdown
Member

The original code can produce:

bash: [: missing `]'

... if $FUNCTIONS_LOG_CONF is not empty.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@tisonkun tisonkun self-assigned this Jan 11, 2023
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jan 11, 2023
@tisonkun

Copy link
Copy Markdown
Member Author

Thanks for your review!

Merging...

@tisonkun
tisonkun merged commit 4b0dc9a into master Jan 11, 2023
@tisonkun
tisonkun deleted the tisonkun-patch-1 branch January 11, 2023 12:06
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants