Skip to content

[fix] Some typos in Cmd classes #19190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisonkun merged 1 commit into from
Jan 12, 2023
Merged

[fix] Some typos in Cmd classes #19190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdPackages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ private class UploadCmd extends CliCommand {
@Parameter(names = "--contact", description = "contact information of a package")
private String contact;

@DynamicParameter(names = {"--properties", "-P"}, description = "external infromations of a package")
@DynamicParameter(names = {"--properties", "-P"}, description = "external information of a package")
private Map<String, String> properties = new HashMap<>();

@Parameter(names = "--path", description = "file path of the package", required = true)
Expand Down
2 changes: 1 addition & 1 deletion pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,7 +1169,7 @@ void run() throws PulsarAdminException, TimeoutException {
Map<Integer, MessageId> messageIds = getTopics().terminatePartitionedTopic(persistentTopic);
for (Map.Entry<Integer, MessageId> entry: messageIds.entrySet()) {
String topicName = persistentTopic + "-partition-" + entry.getKey();
System.out.println("Topic " + topicName + " succesfully terminated at " + entry.getValue());
System.out.println("Topic " + topicName + " successfully terminated at " + entry.getValue());
}
}
}
Expand Down
14 changes: 7 additions & 7 deletions pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,25 +499,25 @@ public static ByteBufPair newMessage(long consumerId, long ledgerId, long entryI
DEFAULT_CONSUMER_EPOCH), metadataAndPayload);
}

public static ByteBufPair newSend(long producerId, long sequenceId, int numMessaegs, ChecksumType checksumType,
public static ByteBufPair newSend(long producerId, long sequenceId, int numMessages, ChecksumType checksumType,
long ledgerId, long entryId, MessageMetadata messageMetadata, ByteBuf payload) {
return newSend(producerId, sequenceId, -1 /* highestSequenceId */, numMessaegs,
return newSend(producerId, sequenceId, -1 /* highestSequenceId */, numMessages,
messageMetadata.hasTxnidLeastBits() ? messageMetadata.getTxnidLeastBits() : -1,
messageMetadata.hasTxnidMostBits() ? messageMetadata.getTxnidMostBits() : -1,
checksumType, ledgerId, entryId, messageMetadata, payload);
}

public static ByteBufPair newSend(long producerId, long sequenceId, int numMessaegs, ChecksumType checksumType,
public static ByteBufPair newSend(long producerId, long sequenceId, int numMessages, ChecksumType checksumType,
MessageMetadata messageMetadata, ByteBuf payload) {
return newSend(producerId, sequenceId, -1 /* highestSequenceId */, numMessaegs,
return newSend(producerId, sequenceId, -1 /* highestSequenceId */, numMessages,
messageMetadata.hasTxnidLeastBits() ? messageMetadata.getTxnidLeastBits() : -1,
messageMetadata.hasTxnidMostBits() ? messageMetadata.getTxnidMostBits() : -1,
checksumType, -1, -1, messageMetadata, payload);
}

public static ByteBufPair newSend(long producerId, long lowestSequenceId, long highestSequenceId, int numMessaegs,
public static ByteBufPair newSend(long producerId, long lowestSequenceId, long highestSequenceId, int numMessages,
ChecksumType checksumType, MessageMetadata messageMetadata, ByteBuf payload) {
return newSend(producerId, lowestSequenceId, highestSequenceId, numMessaegs,
return newSend(producerId, lowestSequenceId, highestSequenceId, numMessages,
messageMetadata.hasTxnidLeastBits() ? messageMetadata.getTxnidLeastBits() : -1,
messageMetadata.hasTxnidMostBits() ? messageMetadata.getTxnidMostBits() : -1,
checksumType, -1, -1, messageMetadata, payload);
Expand Down Expand Up @@ -1993,7 +1993,7 @@ public static ProducerAccessMode convertProducerAccessMode(
case ExclusiveWithFencing:
return ProducerAccessMode.ExclusiveWithFencing;
default:
throw new IllegalArgumentException("Unknonw access mode: " + accessMode);
throw new IllegalArgumentException("Unknown access mode: " + accessMode);
}
}

Expand Down