Skip to content

[fix][txn] fix txn coordinator recover handle committing and aborting txn race condition. #19201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
congbobo184 merged 9 commits into from
Feb 1, 2023
Merged

[fix][txn] fix txn coordinator recover handle committing and aborting txn race condition. #19201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dfe8e70
fix timeout transaction.
thetumbled Jan 12, 2023
3ff9ceb
change patch way.
thetumbled Jan 16, 2023
1cf93c2
change patch way, move recoverTracker to TransactionMetadataStoreServ…
thetumbled Jan 30, 2023
2a8f405
fix.
thetumbled Jan 30, 2023
426883f
change.
thetumbled Jan 30, 2023
e9f2f30
fix.
thetumbled Jan 30, 2023
1a1e07b
fix.
thetumbled Jan 30, 2023
d5199ae
fix check.
thetumbled Jan 30, 2023
c7c2455
fix.
thetumbled Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 66 additions & 59 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/TransactionMetadataStoreService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,54 +133,66 @@ public CompletableFuture<Void> handleTcClientConnect(TransactionCoordinatorID tc
return;
}

openTransactionMetadataStore(tcId).thenAccept((store) -> internalPinnedExecutor.execute(() -> {
stores.put(tcId, store);
LOG.info("Added new transaction meta store {}", tcId);
long endTime = System.currentTimeMillis() + HANDLE_PENDING_CONNECT_TIME_OUT;
while (true) {
// prevent thread in a busy loop.
if (System.currentTimeMillis() < endTime) {
CompletableFuture<Void> future = deque.poll();
if (future != null) {
// complete queue request future
future.complete(null);
} else {
break;
}
} else {
deque.clear();
break;
}
}

completableFuture.complete(null);
tcLoadSemaphore.release();
})).exceptionally(e -> {
internalPinnedExecutor.execute(() -> {
completableFuture.completeExceptionally(e.getCause());
// release before handle request queue,
//in order to client reconnect infinite loop
tcLoadSemaphore.release();
long endTime = System.currentTimeMillis() + HANDLE_PENDING_CONNECT_TIME_OUT;
while (true) {
// prevent thread in a busy loop.
if (System.currentTimeMillis() < endTime) {
CompletableFuture<Void> future = deque.poll();
if (future != null) {
// this means that this tc client connection connect fail
future.completeExceptionally(e);
} else {
break;
}
TransactionTimeoutTracker timeoutTracker = timeoutTrackerFactory.newTracker(tcId);
Comment thread
thetumbled marked this conversation as resolved.
TransactionRecoverTracker recoverTracker =
new TransactionRecoverTrackerImpl(TransactionMetadataStoreService.this,
timeoutTracker, tcId.getId());
openTransactionMetadataStore(tcId, timeoutTracker, recoverTracker).thenAccept(
store -> internalPinnedExecutor.execute(() -> {
// TransactionMetadataStore initialization
// need to use TransactionMetadataStore itself.
// we need to put store into stores map before
// handle committing and aborting transaction.
stores.put(tcId, store);
LOG.info("Added new transaction meta store {}", tcId);
recoverTracker.handleCommittingAndAbortingTransaction();
timeoutTracker.start();

long endTime = System.currentTimeMillis() + HANDLE_PENDING_CONNECT_TIME_OUT;
while (true) {
// prevent thread in a busy loop.
if (System.currentTimeMillis() < endTime) {
CompletableFuture<Void> future = deque.poll();
if (future != null) {
// complete queue request future
future.complete(null);
} else {
deque.clear();
break;
}
} else {
deque.clear();
break;
}
LOG.error("Add transaction metadata store with id {} error", tcId.getId(), e);
});
return null;
});
}

completableFuture.complete(null);
tcLoadSemaphore.release();
})).exceptionally(e -> {
internalPinnedExecutor.execute(() -> {
completableFuture.completeExceptionally(e.getCause());
Comment thread
thetumbled marked this conversation as resolved.
// release before handle request queue,
//in order to client reconnect infinite loop
tcLoadSemaphore.release();
long endTime = System.currentTimeMillis() + HANDLE_PENDING_CONNECT_TIME_OUT;
while (true) {
// prevent thread in a busy loop.
if (System.currentTimeMillis() < endTime) {
CompletableFuture<Void> future = deque.poll();
if (future != null) {
// this means that this tc client connection connect fail
future.completeExceptionally(e);
} else {
break;
}
} else {
deque.clear();
break;
}
}
LOG.error("Add transaction metadata store with id {} error", tcId.getId(), e);
});
return null;
});
} else {
// only one command can open transaction metadata store,
// other will be added to the deque, when the op of openTransactionMetadataStore finished
Expand All @@ -200,9 +212,11 @@ public CompletableFuture<Void> handleTcClientConnect(TransactionCoordinatorID tc
return completableFuture;
}

public CompletableFuture<TransactionMetadataStore> openTransactionMetadataStore(TransactionCoordinatorID tcId) {
final Timer brokerClientSharedTimer =
pulsarService.getBrokerClientSharedTimer();
public CompletableFuture<TransactionMetadataStore>
openTransactionMetadataStore(TransactionCoordinatorID tcId,
TransactionTimeoutTracker timeoutTracker,
TransactionRecoverTracker recoverTracker) {
final Timer brokerClientSharedTimer = pulsarService.getBrokerClientSharedTimer();
final ServiceConfiguration serviceConfiguration = pulsarService.getConfiguration();
final TxnLogBufferedWriterConfig txnLogBufferedWriterConfig = new TxnLogBufferedWriterConfig();
txnLogBufferedWriterConfig.setBatchEnabled(serviceConfiguration.isTransactionLogBatchedWriteEnabled());
Expand All @@ -212,18 +226,11 @@ public CompletableFuture<TransactionMetadataStore> openTransactionMetadataStore(
txnLogBufferedWriterConfig
.setBatchedWriteMaxDelayInMillis(serviceConfiguration.getTransactionLogBatchedWriteMaxDelayInMillis());

return pulsarService.getBrokerService()
.getManagedLedgerConfig(getMLTransactionLogName(tcId)).thenCompose(v -> {
TransactionTimeoutTracker timeoutTracker = timeoutTrackerFactory.newTracker(tcId);
TransactionRecoverTracker recoverTracker =
new TransactionRecoverTrackerImpl(TransactionMetadataStoreService.this,
timeoutTracker, tcId.getId());
return transactionMetadataStoreProvider
.openStore(tcId, pulsarService.getManagedLedgerFactory(), v,
timeoutTracker, recoverTracker,
pulsarService.getConfig().getMaxActiveTransactionsPerCoordinator(),
txnLogBufferedWriterConfig, brokerClientSharedTimer);
});
return pulsarService.getBrokerService().getManagedLedgerConfig(getMLTransactionLogName(tcId)).thenCompose(
v -> transactionMetadataStoreProvider.openStore(tcId, pulsarService.getManagedLedgerFactory(), v,
timeoutTracker, recoverTracker,
pulsarService.getConfig().getMaxActiveTransactionsPerCoordinator(), txnLogBufferedWriterConfig,
brokerClientSharedTimer));
}

public CompletableFuture<Void> removeTransactionMetadataStore(TransactionCoordinatorID tcId) {
Expand Down
2 changes: 0 additions & 2 deletions .../main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@ public void replayComplete() {

} else {
completableFuture.complete(MLTransactionMetadataStore.this);
recoverTracker.handleCommittingAndAbortingTransaction();
timeoutTracker.start();
recoverTime.setRecoverEndTime(System.currentTimeMillis());
}
}
Expand Down