Excluded travis-build.sh from license check - #193
Merged
Conversation
merlimat
approved these changes
Feb 7, 2017
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
fix apache#192 * remove unnecessary register producer * exist check * fix spotbug issue * remove blank line
zzzming
pushed a commit
to zzzming/pulsar
that referenced
this pull request
Oct 30, 2023
…ble logging for Elastic Testcontainers (apache#20671) (apache#193) Cherry-picks upstream apache#20671 (cherry picked from commit e97fe5b) # Conflicts: # tests/integration/src/test/java/org/apache/pulsar/tests/integration/topologies/PulsarCluster.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The first line line "#!/bin/bash" in travis-build.sh seems to confuse the license plugin to think the license header is missing even though its there.
Travis build fails with the following error:
[WARNING] Missing header in: /home/travis/build/yahoo/pulsar/pulsar-client-cpp/travis-build.sh
[ERROR] Failed to execute goal com.mycila:license-maven-plugin:3.0.rc1:check (default) on project pulsar: Some files do not have the expected license header -> [Help 1]
Modifications
Added travis-build.sh to exclude from license check
Result
Build should succeed.