[improve][broker] Replace authenticate with authenticateAsync - #19313
Merged
Conversation
michaeljmarshall
added
area/broker
doc-not-needed
1 task
lhotari
approved these changes
Jan 24, 2023
michaeljmarshall
added a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIP: #12105
Motivation
In order to support
AuthenticationProviderimplementations that only implementauthenticateAsync, we need to replace the call toauthenticatewithauthenticateAsyncin the default method definition inAuthenticationProvider#authenticateHttpRequest.This PR is necessary to get the tests passing in #19292.
I should have implemented #19197 this way from the beginning.
Modifications
authenticatewithauthenticateAsync.Verifying this change
This PR is covered by the tests in
AuthenticationServiceTest.Does this pull request potentially affect one of the following parts:
This is not a breaking change because the code was only just recently introduced to master branch.
Documentation
doc-not-neededMatching PR in forked repository
PR in forked repository: this is a trivial change, so adding label to test now