[fix][test] Add cleanup for NonClosableMockBookKeeper in TestPulsarService - #19328
Merged
nicoloboschi merged 2 commits intoJan 26, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19328 +/- ##
=============================================
+ Coverage 32.31% 63.04% +30.72%
- Complexity 6350 25698 +19348
=============================================
Files 1644 1818 +174
Lines 123711 133079 +9368
Branches 13487 14638 +1151
=============================================
+ Hits 39983 83895 +43912
+ Misses 77828 41488 -36340
- Partials 5900 7696 +1796
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nicoloboschi
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cleanup for NonClosableMockBookKeeper is missing in TestPulsarService.
This PR is a follow up for #19323 and #19326 and improves the TestPulsarService that was added in #19323.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete