Skip to content

[fix][test] Add cleanup for NonClosableMockBookKeeper in TestPulsarService - #19328

Merged
nicoloboschi merged 2 commits into
apache:masterfrom
lhotari:lh-fix-mockbookkeeper-cleanup-with-TestPulsarService
Jan 26, 2023
Merged

[fix][test] Add cleanup for NonClosableMockBookKeeper in TestPulsarService#19328
nicoloboschi merged 2 commits into
apache:masterfrom
lhotari:lh-fix-mockbookkeeper-cleanup-with-TestPulsarService

Conversation

@lhotari

@lhotari lhotari commented Jan 26, 2023

Copy link
Copy Markdown
Member

Motivation

Cleanup for NonClosableMockBookKeeper is missing in TestPulsarService.
This PR is a follow up for #19323 and #19326 and improves the TestPulsarService that was added in #19323.

Modifications

  • Add cleanup solution to TestPulsarService
  • Refactor the brokerServiceFunction (move to the builder)

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 2.12.0 milestone Jan 26, 2023
@lhotari
lhotari requested a review from nicoloboschi January 26, 2023 08:04
@lhotari lhotari self-assigned this Jan 26, 2023
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jan 26, 2023
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #19328 (34c4116) into master (6c014ee) will increase coverage by 30.72%.
The diff coverage is 63.15%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #19328       +/-   ##
=============================================
+ Coverage     32.31%   63.04%   +30.72%     
- Complexity     6350    25698    +19348     
=============================================
  Files          1644     1818      +174     
  Lines        123711   133079     +9368     
  Branches      13487    14638     +1151     
=============================================
+ Hits          39983    83895    +43912     
+ Misses        77828    41488    -36340     
- Partials       5900     7696     +1796     
Flag Coverage Δ
inttests 25.10% <42.10%> (+0.14%) ⬆️
systests 25.62% <50.00%> (+0.08%) ⬆️
unittests 60.32% <44.73%> (+42.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...org/apache/pulsar/common/naming/NamespaceName.java 89.04% <ø> (+19.17%) ⬆️
...ava/org/apache/pulsar/common/naming/TopicName.java 92.66% <ø> (+13.76%) ⬆️
...va/org/apache/pulsar/broker/service/ServerCnx.java 53.40% <36.36%> (+15.28%) ⬆️
...rg/apache/pulsar/functions/worker/WorkerUtils.java 70.50% <50.00%> (+8.43%) ⬆️
...e/pulsar/functions/worker/PulsarWorkerService.java 59.28% <60.00%> (+2.43%) ⬆️
...rg/apache/pulsar/broker/service/BrokerService.java 59.01% <80.00%> (+15.18%) ⬆️
...n/java/org/apache/pulsar/broker/PulsarService.java 74.37% <90.00%> (+5.34%) ⬆️
.../apache/pulsar/common/naming/SystemTopicNames.java 55.55% <0.00%> (-5.56%) ⬇️
.../apache/pulsar/client/impl/ClientCnxIdleState.java 68.88% <0.00%> (-2.23%) ⬇️
...in/java/org/apache/pulsar/common/api/AuthData.java 71.42% <0.00%> (ø)
... and 1206 more

@nicoloboschi
nicoloboschi merged commit e2a056d into apache:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants