[fix][broker] ServerCnx broken after recent cherry-picks - #19521
Merged
michaeljmarshall merged 1 commit intoFeb 15, 2023
Conversation
michaeljmarshall
force-pushed
the
fix-branch-2.11
branch
from
February 14, 2023 23:06
6dff764 to
b996563
Compare
2 tasks
Member
Author
|
The errors are unrelated to the recent cherry picks, I am going to merge this now to unblock the branch. |
michaeljmarshall
added a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Feb 15, 2023
I broke all release branches when I cherry picked 2847dd1 to them. This change takes some of the underlying logic from apache#19409, without taking the async logic. * Make changes to `ServerCnx` to make tests pass Tests are currently failing, so passing tests will show that this solution is correct. - [x] `doc-not-needed` (cherry picked from commit 8246da2)
michaeljmarshall
added a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Feb 15, 2023
I broke all release branches when I cherry picked 2847dd1 to them. This change takes some of the underlying logic from apache#19409, without taking the async logic. * Make changes to `ServerCnx` to make tests pass Tests are currently failing, so passing tests will show that this solution is correct. - [x] `doc-not-needed` (cherry picked from commit 8246da2)
michaeljmarshall
added a commit
that referenced
this pull request
Feb 15, 2023
I broke all release branches when I cherry picked 2847dd1 to them. This change takes some of the underlying logic from #19409, without taking the async logic. * Make changes to `ServerCnx` to make tests pass Tests are currently failing, so passing tests will show that this solution is correct. - [x] `doc-not-needed` (cherry picked from commit 8246da2) (cherry picked from commit 15e4198)
michaeljmarshall
added a commit
that referenced
this pull request
Feb 15, 2023
I broke all release branches when I cherry picked 2847dd1 to them. This change takes some of the underlying logic from #19409, without taking the async logic. * Make changes to `ServerCnx` to make tests pass Tests are currently failing, so passing tests will show that this solution is correct. - [x] `doc-not-needed` (cherry picked from commit 8246da2) (cherry picked from commit 15e4198) (cherry picked from commit 6132b46)
michaeljmarshall
added a commit
that referenced
this pull request
Feb 15, 2023
I broke all release branches when I cherry picked 2847dd1 to them. This change takes some of the underlying logic from #19409, without taking the async logic. * Make changes to `ServerCnx` to make tests pass Tests are currently failing, so passing tests will show that this solution is correct. - [x] `doc-not-needed` (cherry picked from commit 8246da2) (cherry picked from commit 15e4198) (cherry picked from commit 6132b46)
michaeljmarshall
added a commit
to datastax/pulsar
that referenced
this pull request
Feb 15, 2023
I broke all release branches when I cherry picked 2847dd1 to them. This change takes some of the underlying logic from apache#19409, without taking the async logic. * Make changes to `ServerCnx` to make tests pass Tests are currently failing, so passing tests will show that this solution is correct. - [x] `doc-not-needed` (cherry picked from commit 8246da2) (cherry picked from commit 15e4198) (cherry picked from commit 6132b46)
michaeljmarshall
added
cherry-picked/branch-2.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I broke all release branches when I cherry picked 2847dd1 to them. This change takes some of the underlying logic from #19409, without taking the async logic.
Modifications
ServerCnxto make tests passVerifying this change
Tests are currently failing, so passing tests will show that this solution is correct.
Documentation
doc-not-needed