Revert "[improve] configure whether function consumer should skip to latest (#17214)" - #19651
Closed
michaeljmarshall wants to merge 1 commit into
Closed
Revert "[improve] configure whether function consumer should skip to latest (#17214)"#19651michaeljmarshall wants to merge 1 commit into
michaeljmarshall wants to merge 1 commit into
Conversation
…latest (apache#17214)" This reverts commit bf982f4.
michaeljmarshall
added
area/function
doc-not-needed
michaeljmarshall
requested review from
eolivelli,
freeznet,
liudezhi2098 and
nlu90
February 27, 2023 19:46
Member
|
@michaeljmarshall When is the next release? Let's do an expedited discussion in the mailing list before reverting the change if the release date is not this week. |
Member
|
@michaeljmarshall I just sent out the discussion email, could you take a look and provide feedback? |
|
The pr had no activity for 30 days, mark with Stale label. |
Member
Author
|
@nlu90 - thanks for taking care of the discussion. I am not opinionated on the change in the commit. I just wanted to make sure we gave people a chance to discuss the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit bf982f4.
Motivation
In #17214, we added a new protobuf field without a PIP. In order to ensure this code is not released, I propose that we revert this commit now and only move forward once it has been accepted through a PIP (or a discussion on the mailing list if a PIP is deemed unnecessary).
Documentation
doc-not-neededThis is just reverting a commit, and there were no external docs merged for that commit, so no docs need to be updated.