Skip to content

[fix][test] testModularLoadManagerRemoveBundleAndLoad - #19710

Merged
AnonHxy merged 1 commit into
apache:masterfrom
AnonHxy:fix_testModularLoadManagerRemoveBundleAndLoad
Mar 6, 2023
Merged

[fix][test] testModularLoadManagerRemoveBundleAndLoad#19710
AnonHxy merged 1 commit into
apache:masterfrom
AnonHxy:fix_testModularLoadManagerRemoveBundleAndLoad

Conversation

@AnonHxy

@AnonHxy AnonHxy commented Mar 4, 2023

Copy link
Copy Markdown
Contributor

Motivation

Fixes #19656 (comment)

Modifications

Replacing ScheduledExecutorService to ExecutorService in testModularLoadManagerRemoveBundleAndLoad

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: AnonHxy#31

@AnonHxy

AnonHxy commented Mar 4, 2023

Copy link
Copy Markdown
Contributor Author

@heesung-sn PTAL

@tisonkun tisonkun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is there any change we can move some cases or the test out of flaky tests? I guess we omit this test failure in #19656 because it's in flaky group :P

@tisonkun tisonkun changed the title [test][fix] Fix testModularLoadManagerRemoveBundleAndLoad failure [fix][test] testModularLoadManagerRemoveBundleAndLoad Mar 4, 2023
@tisonkun

tisonkun commented Mar 4, 2023

Copy link
Copy Markdown
Member

Flaky group tests pass but uploading Codecov failed. cc @yaalsn maybe you can take a look? https://github.com/apache/pulsar/actions/runs/4329101285/jobs/7559476284

@AnonHxy

AnonHxy commented Mar 6, 2023

Copy link
Copy Markdown
Contributor Author

LGTM.

Is there any change we can move some cases or the test out of flaky tests? I guess we omit this test failure in #19656 because it's in flaky group :P

It‘s not easy that we could always find the failure flaky tests. Maybe we could change all the flaky tests stable in a separate thread I think.

@AnonHxy
AnonHxy merged commit 4ed8a87 into apache:master Mar 6, 2023
lhotari pushed a commit that referenced this pull request Mar 5, 2024
(cherry picked from commit 4ed8a87)

# Conflicts:
#	pulsar-broker/src/test/java/org/apache/pulsar/broker/namespace/NamespaceServiceTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants