[fix] [broker] delete topic failed if disabled system topic - #19735
Merged
poorbarcode merged 2 commits intoMar 9, 2023
Conversation
poorbarcode
added
type/bug
Technoboy-
approved these changes
Mar 8, 2023
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19735 +/- ##
=============================================
+ Coverage 25.22% 62.02% +36.79%
- Complexity 205 3500 +3295
=============================================
Files 1670 1848 +178
Lines 126397 135871 +9474
Branches 13797 14953 +1156
=============================================
+ Hits 31887 84274 +52387
+ Misses 89540 43851 -45689
- Partials 4970 7746 +2776
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Technoboy-
pushed a commit
that referenced
this pull request
Mar 13, 2023
Motivation: After PR #18823, The cmd delete topic will fail if disabled the feature system topic. Modifications: do not delete the system policy if disabled the feature system topic
poorbarcode
added a commit
that referenced
this pull request
May 6, 2023
coderzc
pushed a commit
that referenced
this pull request
May 31, 2023
Member
|
As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After PR #18823, The cmd
delete topicwill fail if disabled the featuresystem topic.Modifications
do not delete the system policy if disabled the feature
system topicDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: