Skip to content

[improve][meta] Fix busy-loop causes watcher can't acquire lock. #19769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattisonchao merged 11 commits into from
Mar 13, 2023
Merged

[improve][meta] Fix busy-loop causes watcher can't acquire lock. #19769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
542cc5a
[fix][metadata] Fix notification thread block causes double owner.
mattisonchao Mar 8, 2023
7adf86f
Fix the doc
mattisonchao Mar 8, 2023
1e4d638
Fix checkstyle
mattisonchao Mar 8, 2023
1a6082f
[fix][meta] Fix busy-loop causes watch can't acquire lock.
mattisonchao Mar 9, 2023
3ff1041
Revert "Fix checkstyle"
mattisonchao Mar 9, 2023
ccd8eff
Revert "Fix the doc"
mattisonchao Mar 9, 2023
7127bf3
Revert "[fix][metadata] Fix notification thread block causes double o…
mattisonchao Mar 9, 2023
0de94b7
Revert some useless code
mattisonchao Mar 9, 2023
8f95e66
Fix checlstyle
mattisonchao Mar 9, 2023
827d625
Revert useless changes
mattisonchao Mar 9, 2023
f250d10
Revert useless code
mattisonchao Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKSessionWatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ public ZKSessionWatcher(ZooKeeper zk, Consumer<SessionEvent> sessionListener) {
this.scheduler = Executors
.newSingleThreadScheduledExecutor(new DefaultThreadFactory("metadata-store-zk-session-watcher"));
this.task =
scheduler.scheduleAtFixedRate(catchingAndLoggingThrowables(this::checkConnectionStatus), tickTimeMillis,
scheduler.scheduleWithFixedDelay(
catchingAndLoggingThrowables(this::checkConnectionStatus), tickTimeMillis,
tickTimeMillis,
TimeUnit.MILLISECONDS);
this.currentStatus = SessionEvent.SessionReestablished;
Expand Down
2 changes: 1 addition & 1 deletion pulsar-metadata/src/test/java/org/apache/pulsar/metadata/ZKSessionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
import org.awaitility.Awaitility;
import org.testng.annotations.Test;

@Test(groups = "quarantine")
@Test
public class ZKSessionTest extends BaseMetadataStoreTest {

@Test
Expand Down