[cleanup][proxy] Remove authorization config - #19797
Conversation
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
4ee0086 to
8bde2e7
Compare
tisonkun
left a comment
There was a problem hiding this comment.
Does passing unknown key-value pairs cause fatal? I'm afraid that users will continue using existing conf file that contains now removed key value pair.
No impact. Users can continue the old config, the proxy didn't use these configs. |
michaeljmarshall
left a comment
There was a problem hiding this comment.
I see that the proxy itself does not use the AuthorizationService. However, proxy extensions can use the AuthorizationService, so I don't think we can remove it without discussion on the mailing list. I know, for example, that the DataStax project starlight-for-kafka uses the AuthorizationService here. That being said, I could see an argument for removing the AuthorizationService from the proxy and then we can expect extension maintainers to build their own AuthorizationService.
|
Good catch! I didn't notice the proxy extensions, I can add the What do you think of that? @michaeljmarshall |
|
I thought that might work, but @eolivelli thinks we should keep it around. It sounds like the kind of decision to make on the mailing list. |
|
The pr had no activity for 30 days, mark with Stale label. |
Motivation
In #1002, authorization is no longer done by proxy, so I clean up the proxy authorization.
Modifications
superUserRoles,authorizationEnabled, andauthorizationProviderfrom the proxy configDocumentation
docdoc-requireddoc-not-neededdoc-complete