Skip to content

[fix][broker] Copy subscription properties during updating the topic partition number. - #19800

Merged
Technoboy- merged 1 commit into
apache:branch-2.11from
mattisonchao:cherry-pick/19223
Mar 15, 2023
Merged

[fix][broker] Copy subscription properties during updating the topic partition number.#19800
Technoboy- merged 1 commit into
apache:branch-2.11from
mattisonchao:cherry-pick/19223

Conversation

@mattisonchao

@mattisonchao mattisonchao commented Mar 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

This PR is cherry-picking original PR #19223

  • doc-not-needed

@mattisonchao mattisonchao self-assigned this Mar 14, 2023
@github-actions

github-actions Bot commented Mar 14, 2023

Copy link
Copy Markdown

@mattisonchao Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@mattisonchao mattisonchao reopened this Mar 14, 2023
@mattisonchao mattisonchao added this to the 3.0.0 milestone Mar 14, 2023
@codelipenghui

codelipenghui commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

@mattisonchao I think it should be a bug fix, not an improvement. No one will treat the fixing of the missed subscription's properties as an improvements.

@Technoboy- Technoboy- changed the title [improve][broker] Copy subscription properties during updating the topic partition number. [fix][broker] Copy subscription properties during updating the topic partition number. Mar 14, 2023
@Technoboy- Technoboy- closed this Mar 14, 2023
@Technoboy- Technoboy- reopened this Mar 14, 2023
@congbobo184 congbobo184 added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Mar 14, 2023
@github-actions github-actions Bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Mar 14, 2023
@Technoboy- Technoboy- closed this Mar 14, 2023
@Technoboy- Technoboy- reopened this Mar 14, 2023
@Technoboy- Technoboy- added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Mar 14, 2023
@github-actions github-actions Bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Mar 14, 2023
@mattisonchao

mattisonchao commented Mar 14, 2023

Copy link
Copy Markdown
Member Author

@codelipenghui Let me change the original PR title. Thanks for your reminder.

@github-actions github-actions Bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Mar 14, 2023
@Technoboy-
Technoboy- merged commit 0e32ab4 into apache:branch-2.11 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes
@congbobo184 congbobo184 congbobo184 approved these changes

Assignees

@mattisonchao mattisonchao

Labels

cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs ready-to-test release/2.11.1

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mattisonchao @codelipenghui @congbobo184 @Technoboy-