Skip to content

[fix][branch-2.11] Fix delete system topic clean topic policy (#18823) - #19835

Merged
Technoboy- merged 5 commits into
branch-2.11from
delete_ns
Mar 20, 2023
Merged

[fix][branch-2.11] Fix delete system topic clean topic policy (#18823)#19835
Technoboy- merged 5 commits into
branch-2.11from
delete_ns

Conversation

@liangyepianzhou

@liangyepianzhou liangyepianzhou commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

Motivation

Cherry-pick #18823 to branch-2.11

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

If users set topic policy for system topic, then delete this system topic, the topic policy should be deleted.

Only change_events topic do not need to clear topic policies.

(cherry picked from commit 93c41de)
@liangyepianzhou liangyepianzhou self-assigned this Mar 16, 2023
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Mar 16, 2023
@Technoboy- Technoboy- closed this Mar 20, 2023
@Technoboy- Technoboy- reopened this Mar 20, 2023
@Technoboy-
Technoboy- merged commit 5eb0ce2 into branch-2.11 Mar 20, 2023
@codelipenghui
codelipenghui deleted the delete_ns branch April 4, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants