Skip to content

[fix][broker]Add origin signature for compatible. - #19857

Closed
horizonzy wants to merge 1 commit into
apache:masterfrom
horizonzy:add-origin-signature-for-compatible
Closed

[fix][broker]Add origin signature for compatible.#19857
horizonzy wants to merge 1 commit into
apache:masterfrom
horizonzy:add-origin-signature-for-compatible

Conversation

@horizonzy

@horizonzy horizonzy commented Mar 20, 2023

Copy link
Copy Markdown
Member

Fixes #xyz

Master Issue: #xyz

Motivation

Some users may the following method to create resources.

public static MetadataStoreExtended createLocalMetadataStore(String serverUrls, int sessionTimeoutMs)

In #19156, we change the signature, which may introduce the compatible problem. So here we maintain the origin signature.

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions

Copy link
Copy Markdown

@horizonzy Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions Bot added doc-required Your PR changes impact docs and you will update later. and removed doc-label-missing labels Mar 20, 2023
@horizonzy horizonzy changed the title Add origin signature for compatible. [fix][broker]Add origin signature for compatible. Mar 20, 2023
@github-actions github-actions Bot added doc-not-needed Your PR changes do not impact docs and removed doc-required Your PR changes impact docs and you will update later. labels Mar 20, 2023
@tisonkun

Copy link
Copy Markdown
Member

Some users may the following method to create resources.

Do you have a real-world report? I'm wondering how an internal method (broker is not exported to user) gets used.

@horizonzy

Copy link
Copy Markdown
Member Author

Some users may the following method to create resources.

Do you have a real-world report? I'm wondering how an internal method (broker is not exported to user) gets used.

Yes, it's a little strange. It should only be used on the pulsar broker side.
In the pulsar function mesh, it uses PulsarResources to create a meta store to debug. So the function mesh compiles error using the new release.
At now, the pulsar function mesh removes the usage.

@horizonzy horizonzy closed this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants