[fix][broker]Add origin signature for compatible. - #19857
Closed
horizonzy wants to merge 1 commit into
Closed
Conversation
|
@horizonzy Please add the following content to your PR description and select a checkbox: |
coderzc
approved these changes
Mar 20, 2023
Member
Do you have a real-world report? I'm wondering how an internal method (broker is not exported to user) gets used. |
Member
Author
Yes, it's a little strange. It should only be used on the pulsar broker side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Master Issue: #xyz
Motivation
Some users may the following method to create resources.
In #19156, we change the signature, which may introduce the compatible problem. So here we maintain the origin signature.
docdoc-requireddoc-not-neededdoc-complete