[fix][fn] Make pulsar-admin support update py/go with package url - #19897
Merged
Technoboy- merged 1 commit intoMay 10, 2023
Merged
Conversation
freeznet
approved these changes
Mar 23, 2023
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
|
If we could backport this to at least 2.10 when it lands, you would make my year. |
nlu90
approved these changes
Mar 27, 2023
Member
|
@codelipenghui Can we backport this fix to 2.10? |
2 tasks
Contributor
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #19897 +/- ##
=============================================
+ Coverage 24.42% 62.06% +37.64%
- Complexity 291 3507 +3216
=============================================
Files 1603 1859 +256
Lines 124343 136741 +12398
Branches 13571 15033 +1462
=============================================
+ Hits 30369 84875 +54506
+ Misses 89490 44083 -45407
- Partials 4484 7783 +3299
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jiangpengcheng
force-pushed
the
fix_function_update_command
branch
from
May 4, 2023 08:12
415635f to
67407fe
Compare
Contributor
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Member
|
This is a pretty clear bug, so I cherry picked it to several release branches. |
michaeljmarshall
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 25, 2023
…ache#19897) (cherry picked from commit fb9c4d0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18966
Master Issue: #xyz
PIP: #xyz
Motivation
pulsar-admin functions update doesn't support package URL for python and golang
Modifications
Fix
Verifying this change
(Please pick either of the following options)
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: jiangpengcheng#9