[fix][fn] Support multiple input topics for Go runtime - #20000
Merged
Technoboy- merged 8 commits intoMay 10, 2023
Conversation
jiangpengcheng
changed the title
Contributor
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot rerun-failure-checks |
jiangpengcheng
force-pushed
the
support_multiple_topics_for_go
branch
2 times, most recently
from
April 7, 2023 02:24
1029f31 to
a062819
Compare
Contributor
Author
|
/pulsarbot rerun-failure-checks |
jiangpengcheng
force-pushed
the
support_multiple_topics_for_go
branch
from
April 10, 2023 09:28
96663c2 to
f83ca47
Compare
Contributor
Author
|
/pulsarbot rerun-failure-checks |
jiangpengcheng
force-pushed
the
support_multiple_topics_for_go
branch
from
April 11, 2023 01:11
f83ca47 to
ffa50cc
Compare
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20000 +/- ##
=============================================
+ Coverage 33.13% 72.99% +39.86%
- Complexity 12164 31932 +19768
=============================================
Files 1497 1868 +371
Lines 114032 138294 +24262
Branches 12373 15213 +2840
=============================================
+ Hits 37782 100945 +63163
+ Misses 71340 29336 -42004
- Partials 4910 8013 +3103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
/pulsarbot rerun-failure-checks |
freeznet
approved these changes
Apr 11, 2023
cbornet
requested changes
Apr 11, 2023
Comment on lines
692
to
698
| if (isTopicPattern || multipleInput) { | ||
| if (isTopicPattern) { | ||
| inputTopicName = inputTopicName + ".*"; | ||
| } else { | ||
| inputTopicName = inputTopicName + "1," + inputTopicName + "2"; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (isTopicPattern || multipleInput) { | |
| if (isTopicPattern) { | |
| inputTopicName = inputTopicName + ".*"; | |
| } else { | |
| inputTopicName = inputTopicName + "1," + inputTopicName + "2"; | |
| } | |
| } | |
| if (isTopicPattern) { | |
| inputTopicName = inputTopicName + ".*"; | |
| } else if (multipleInput) { | |
| inputTopicName = inputTopicName + "1," + inputTopicName + "2"; | |
| } | |
| } |
nlu90
approved these changes
Apr 11, 2023
Comment on lines
63
to
65
| // for backward compatibility | ||
| SourceSpecTopic string `json:"sourceSpecsTopic" yaml:"sourceSpecsTopic"` | ||
| SourceSchemaType string `json:"sourceSchemaType" yaml:"sourceSchemaType"` |
Member
There was a problem hiding this comment.
you should mark Deprecated for fields that's not intended for use
jiangpengcheng
force-pushed
the
support_multiple_topics_for_go
branch
from
April 12, 2023 06:39
3a9cfb8 to
5706991
Compare
cbornet
approved these changes
Apr 12, 2023
poorbarcode
pushed a commit
that referenced
this pull request
May 30, 2023
(cherry picked from commit f04252b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19981
Master Issue: #xyz
PIP: #xyz
Motivation
The Go runtime doesn't support multi-input topics,
Modifications
Add a map<string, string> field
SourceInputSpecsto theGoInstanceConfig, while the key is topic name, and value is the json string ofConsumerSpec, so that the Go instance can unmarshal it to amap[string]ConsumerSpecand support multiple input topicsVerifying this change
Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: jiangpengcheng#10