Skip to content

[feat][sql] Bump Trino version to 368 and fix Decimal breaking change - #20016

Merged
tisonkun merged 7 commits into
apache:masterfrom
tisonkun:bump-trino-368
Apr 10, 2023
Merged

[feat][sql] Bump Trino version to 368 and fix Decimal breaking change#20016
tisonkun merged 7 commits into
apache:masterfrom
tisonkun:bump-trino-368

Conversation

@tisonkun

@tisonkun tisonkun commented Apr 5, 2023

Copy link
Copy Markdown
Member

This is a follow-up to #16683.

And it fixes one of the breaking changes noted at #16494.

The final goal should be catching up to the latest trino version. For compatibility, the Trino community says:

We generally do our best to avoid making breaking changes in SPI, but we still do them from time to time.

There is a revapi test in SPI which provides compatibility guarantees one version back, but we sometimes have to do exclusions there to enable innovation.

TL;DR is it’s recommended to build a plugin version for a specific Trino version

So it seems the breaking changes and incompatibility is how Trino users should be familiar with.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

tisonkun added 2 commits April 5, 2023 19:12
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
tisonkun requested review from Technoboy- and merlimat April 5, 2023 11:19
@tisonkun tisonkun self-assigned this Apr 5, 2023
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Apr 5, 2023
tisonkun added 4 commits April 5, 2023 19:33
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
tisonkun marked this pull request as draft April 6, 2023 16:52
@tisonkun

tisonkun commented Apr 6, 2023

Copy link
Copy Markdown
Member Author

Still some compatibility issue. Convert to draft for now.

@tisonkun
tisonkun marked this pull request as ready for review April 6, 2023 19:16
Signed-off-by: tison <wander4096@gmail.com>
@codecov-commenter

codecov-commenter commented Apr 6, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.85%. Comparing base (8c50a6c) to head (ddc4f07).
⚠️ Report is 2674 commits behind head on master.

Files with missing lines Patch % Lines
...ql/presto/decoder/json/PulsarJsonFieldDecoder.java 45.45% 2 Missing and 4 partials ⚠️
...l/presto/decoder/avro/PulsarAvroColumnDecoder.java 50.00% 2 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #20016       +/-   ##
=============================================
+ Coverage     33.17%   72.85%   +39.67%     
- Complexity    12158    31628    +19470     
=============================================
  Files          1499     1861      +362     
  Lines        113832   137492    +23660     
  Branches      12368    15145     +2777     
=============================================
+ Hits          37769   100170    +62401     
+ Misses        71143    29346    -41797     
- Partials       4920     7976     +3056     
Flag Coverage Δ
inttests 24.35% <ø> (?)
systests 25.04% <ø> (?)
unittests 72.12% <54.16%> (+38.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...esto/decoder/json/PulsarJsonRowDecoderFactory.java 75.75% <100.00%> (ø)
...l/presto/decoder/avro/PulsarAvroColumnDecoder.java 60.41% <50.00%> (ø)
...ql/presto/decoder/json/PulsarJsonFieldDecoder.java 63.02% <45.45%> (ø)

... and 1530 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tisonkun

tisonkun commented Apr 7, 2023

Copy link
Copy Markdown
Member Author

@merlimat @Technoboy- This patch should be ready to review.

The only failed CI is about Spring dep CVE. We actually filter out all pulsar-sql when running OWASP so it should be unrelated.

@tisonkun
tisonkun requested a review from MarvinCai April 7, 2023 02:03
@tisonkun

Copy link
Copy Markdown
Member Author

Merging...

Thanks for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants