[feat][sql] Bump Trino version to 368 and fix Decimal breaking change - #20016
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
marked this pull request as draft
April 6, 2023 16:52
Member
Author
|
Still some compatibility issue. Convert to draft for now. |
tisonkun
marked this pull request as ready for review
April 6, 2023 19:16
Signed-off-by: tison <wander4096@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #20016 +/- ##
=============================================
+ Coverage 33.17% 72.85% +39.67%
- Complexity 12158 31628 +19470
=============================================
Files 1499 1861 +362
Lines 113832 137492 +23660
Branches 12368 15145 +2777
=============================================
+ Hits 37769 100170 +62401
+ Misses 71143 29346 -41797
- Partials 4920 7976 +3056
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
@merlimat @Technoboy- This patch should be ready to review. The only failed CI is about Spring dep CVE. We actually filter out all pulsar-sql when running OWASP so it should be unrelated. |
MarvinCai
approved these changes
Apr 7, 2023
Technoboy-
approved these changes
Apr 7, 2023
Member
Author
|
Merging... Thanks for your review. |
2 tasks
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #16683.
And it fixes one of the breaking changes noted at #16494.
The final goal should be catching up to the latest trino version. For compatibility, the Trino community says:
So it seems the breaking changes and incompatibility is how Trino users should be familiar with.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: