Skip to content

[fix][build] Fix publish image script #20305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodece merged 1 commit into from
May 12, 2023
Merged

[fix][build] Fix publish image script #20305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docker/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ set -x
# Fail if any of the subsequent commands fail
set -e

docker tag pulsar:latest ${docker_registry_org}/pulsar:latest
docker tag pulsar-all:latest ${docker_registry_org}/pulsar-all:latest
docker tag apachepulsar/pulsar:latest ${docker_registry_org}/pulsar:latest
docker tag apachepulsar/pulsar-all:latest ${docker_registry_org}/pulsar-all:latest
Comment on lines +65 to +66

@michaeljmarshall michaeljmarshall May 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this will override "latest" when we release older versions? For example, when we release 3.1.0, we wouldn't want some 3.0.x release to overwrite "latest" in my opinion.

@michaeljmarshall michaeljmarshall May 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know your PR didn't change this. I just noticed it after reading your PR description and wanted to ask.

@nodece nodece May 13, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this will override "latest" when we release older versions? For example, when we release 3.1.0, we wouldn't want some 3.0.x release to overwrite "latest" in my opinion.

I have never bumped the Pulsar, but I know we have this issue, see #19544

Perhaps we need to update the release document, and update the publish script.

@michaeljmarshall michaeljmarshall May 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing that reference. I reopened and commented on the issue.


docker tag pulsar:latest ${docker_registry_org}/pulsar:$MVN_VERSION
docker tag pulsar-all:latest ${docker_registry_org}/pulsar-all:$MVN_VERSION
docker tag apachepulsar/pulsar:latest ${docker_registry_org}/pulsar:$MVN_VERSION
docker tag apachepulsar/pulsar-all:latest ${docker_registry_org}/pulsar-all:$MVN_VERSION

# Push all images and tags
docker push ${docker_registry_org}/pulsar:latest
Expand Down