Skip to content

[fix][test] Fix test testThreadSwitchOfZkMetadataStore - #20446

Merged
Technoboy- merged 3 commits into
apache:branch-2.11from
poorbarcode:fix_test/testThreadSwitchOfZkMetadataStore
Jun 1, 2023
Merged

[fix][test] Fix test testThreadSwitchOfZkMetadataStore#20446
Technoboy- merged 3 commits into
apache:branch-2.11from
poorbarcode:fix_test/testThreadSwitchOfZkMetadataStore

Conversation

@poorbarcode

@poorbarcode poorbarcode commented May 31, 2023

Copy link
Copy Markdown
Contributor

Motivation

After the PR #20303 was cherry-picked inti branch-2.11, the test testThreadSwitchOfZkMetadataStore was failed.

The root cause: the attribute metadataStoreName is a new attribute provided by the PR #17041, at it released at 3.0.0, so it is not included in branch-2.11, so the name of thread-pool of Metadata store is a fixed value metadata-store

protected AbstractMetadataStore() {
    this.executor = Executors
            .newSingleThreadScheduledExecutor(new DefaultThreadFactory("metadata-store"));
    registerListener(this);
    ...
}

Modifications

Instead of a special value, verify the name of the thread pool by the fixed value metadata-store

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@Technoboy- Technoboy- changed the title [branch-2.11] [fix] [test]fix test testThreadSwitchOfZkMetadataStore [fix][test] Fix test testThreadSwitchOfZkMetadataStore Jun 1, 2023
@Technoboy-
Technoboy- merged commit c54edc9 into apache:branch-2.11 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants