Skip to content

[fix] [broker]Consumption stuck due to orphan consumers after the connection reconnect #20573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
poorbarcode wants to merge 2 commits into from
Closed

[fix] [broker]Consumption stuck due to orphan consumers after the connection reconnect #20573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8988f68
[fix] [broker]Consumption stuck due to orphan consumers after connect…
poorbarcode Jun 13, 2023
af415ba
Update pulsar-broker/src/main/java/org/apache/pulsar/broker/service/S…
poorbarcode Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,20 +1243,11 @@ protected void handleSubscribe(final CommandSubscribe subscribe) {
return topic.subscribe(option);
}
})
.thenAccept(consumer -> {
if (consumerFuture.complete(consumer)) {
log.info("[{}] Created subscription on topic {} / {}",
remoteAddress, topicName, subscriptionName);
commandSender.sendSuccessResponse(requestId);
if (brokerInterceptor != null) {
try {
brokerInterceptor.consumerCreated(this, consumer, metadata);
} catch (Throwable t) {
log.error("Exception occur when intercept consumer created.", t);
}
}
} else {
// The consumer future was completed before by a close command
.thenAcceptAsync(consumer -> {
if (!consumerFuture.complete(consumer) || !isActive()) {
// Two cases:
// 1. The consumer future was completed before by a close command.
// 2. The consumer future was completed after the ServerCnx closed.
try {
consumer.close();
log.info("[{}] Cleared consumer created after timeout on client side {}",
Expand All @@ -1268,9 +1259,20 @@ protected void handleSubscribe(final CommandSubscribe subscribe) {
remoteAddress, consumer, e.getMessage());
}
consumers.remove(consumerId, consumerFuture);
} else {
log.info("[{}] Created subscription on topic {} / {}",
remoteAddress, topicName, subscriptionName);
commandSender.sendSuccessResponse(requestId);
if (brokerInterceptor != null) {
try {
brokerInterceptor.consumerCreated(this, consumer, metadata);
} catch (Throwable t) {
log.error("Exception occur when intercept consumer created.", t);
}
}
}

})
}, ctx().channel().eventLoop())
.exceptionally(exception -> {
if (exception.getCause() instanceof ConsumerBusyException) {
if (log.isDebugEnabled()) {
Expand Down