[fix][broker] Fix Filter NPE - #20711
Closed
Technoboy- wants to merge 2 commits into
Closed
Conversation
yaalsn
approved these changes
Jul 4, 2023
nodece
approved these changes
Jul 4, 2023
coderzc
approved these changes
Jul 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After merging #20422 , the broker may encounter NPE when config :
See
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/web/ProcessHandlerFilter.java
Lines 38 to 53 in dc25810
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/BrokerInterceptors.java
Lines 60 to 64 in dc25810
The master branch has fixed this by #19376
For the judgment of interceptors, we need to be consistent with the master, that is, to use the
disableBrokerInterceptorsjudgment firstDocumentation
docdoc-requireddoc-not-neededdoc-complete